Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: tweak JVM memory limit for release job #1237

Merged
merged 2 commits into from
Jul 1, 2024
Merged

ci: tweak JVM memory limit for release job #1237

merged 2 commits into from
Jul 1, 2024

Conversation

patlo-iog
Copy link
Contributor

@patlo-iog patlo-iog commented Jul 1, 2024

Description:

Increase memory limit because release process has been consistenly failing due to high-pressured GC causing weird issue.

Screenshot_2024-07-01_14-43-53

Screenshot_2024-07-01_14-43-35

Screenshot_2024-07-01_14-42-54

The release job run is green https://github.com/hyperledger/identus-cloud-agent/actions/runs/9739373037

Alternatives Considered (optional):

Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@patlo-iog patlo-iog changed the title ci: tweak JVM memory for release job ci: tweak JVM memory for release job [WIP] Jul 1, 2024
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Integration Test Results

16 files  ±0  16 suites  ±0   2s ⏱️ ±0s
34 tests ±0  34 ✅ ±0  0 💤 ±0  0 ❌ ±0 
59 runs  ±0  59 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 08a1198. ± Comparison against base commit 73e8e24.

♻️ This comment has been updated with latest results.

Pat Losoponkul added 2 commits July 1, 2024 15:12
Signed-off-by: Pat Losoponkul <[email protected]>

test: remove println

Signed-off-by: Pat Losoponkul <[email protected]>

chore(release): cut Identus Cloud agent 1.37.0-snapshot.test.1 release

* avoid name and operationId conflict when creating oas client ([#1233](#1233)) ([73e8e24](73e8e24))
* incorrect parsing of public key coordinates and enable some tests again ([#1215](#1215)) ([5398a75](5398a75))
* KeyID from String to Opaque Type and presentation job cleanup  ([#1190](#1190)) ([b813faf](b813faf))
* make init-script.sh idempotent [#1173](#1173) ([#1194](#1194)) ([1712062](1712062))
* migrate and repair in case of renaming issues ([#1211](#1211)) ([cb4d479](cb4d479))
* Present Error Handling (Part 1: Repo Changes) ([#1172](#1172)) ([13e2447](13e2447))
* Present Error Handling Job ([#1204](#1204)) ([3191d8b](3191d8b))
* present error handling Part 2 ([#1177](#1177)) ([9ac6e52](9ac6e52))
* Verification Policy Error Handling ([#1228](#1228)) ([6117a3c](6117a3c))

* add oidc4vci protocol MVP ([#1182](#1182)) ([3ae91dc](3ae91dc))
* add schemaId to the issuance session ([#1199](#1199)) ([97f5d83](97f5d83))
* add support for EcdsaSecp256k1Signature2019Proof and fix pk encoding for EddsaJcs2022Proof ([#1127](#1127)) ([e617ded](e617ded))
* **agent:** add browser fingerprint label to http metrics ([#1231](#1231)) ([f090554](f090554))
* ATL 6829 - Integrate ZIO failures and defects ADR in credential status list ([#1175](#1175)) ([dffad1d](dffad1d))
* ATL-6832 ZIO failures and defects in entity controller ([#1203](#1203)) ([9050094](9050094))
* ATL-6833 integrate ZIO failures and defects in wallet event controller ([#1186](#1186)) ([8bc2018](8bc2018))
* ATL-6834 Use ZIO Failures and Defects effectively in the Issue flow ([#1139](#1139)) ([ede7b77](ede7b77))
* Handle Error in Background Jobs - Improve the way we store errors and defects in DB ([#1218](#1218)) ([e3cadc9](e3cadc9))
* implement ADR Use ZIO Failures and Defects Effectively - Mercury should not throw exceptions ([#1192](#1192)) ([a4ce87f](a4ce87f))
* improve OpenAPI's PresentProof to make more consistent ([#1130](#1130)) ([bdc5d20](bdc5d20))
* Integrate ZIO failures and defects ADR in DID Registrar Controller and Mercury ([#1180](#1180)) ([d8e2120](d8e2120))
* SDJWT holder key binding ([#1185](#1185)) ([628f2f0](628f2f0))
* use kid in the jwt proof header of OID4VCI CredentialIssue request ([#1184](#1184)) ([ee53eda](ee53eda))
* use the compact format in SD-JWT ([#1169](#1169)) ([65da651](65da651))

Signed-off-by: Allain Magyar <[email protected]>
Signed-off-by: Pat Losoponkul <[email protected]>
Signed-off-by: Pat Losoponkul <[email protected]>
@patlo-iog patlo-iog changed the title ci: tweak JVM memory for release job [WIP] ci: tweak JVM memory limit for release job Jul 1, 2024
@patlo-iog patlo-iog marked this pull request as ready for review July 1, 2024 08:33
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Unit Test Results

 96 files  ±0   96 suites  ±0   21m 54s ⏱️ -31s
826 tests ±0  818 ✅ ±0  8 💤 ±0  0 ❌ ±0 
833 runs  ±0  825 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 08a1198. ± Comparison against base commit 73e8e24.

This pull request removes 12 and adds 12 tests. Note that renamed tests count towards both.
org.hyperledger.identus.iam.authentication.oidc.KeycloakAuthenticatorSpec ‑ KeycloakAuthenticatorSepc - authenticate - authenticate entity with multiple role not support
org.hyperledger.identus.iam.authentication.oidc.KeycloakAuthenticatorSpec ‑ KeycloakAuthenticatorSepc - authenticate - authenticate entity with specified role
org.hyperledger.identus.iam.authentication.oidc.KeycloakAuthenticatorSpec ‑ KeycloakAuthenticatorSepc - authenticate - authenticate entity with tenant role if not specified
org.hyperledger.identus.iam.authentication.oidc.KeycloakAuthenticatorSpec ‑ KeycloakAuthenticatorSepc - authorizeWalletAccess - admin role is not authorized for wallet access
org.hyperledger.identus.iam.authentication.oidc.KeycloakAuthenticatorSpec ‑ KeycloakAuthenticatorSepc - authorizeWalletAccess - allow token with a permitted wallet
org.hyperledger.identus.iam.authentication.oidc.KeycloakAuthenticatorSpec ‑ KeycloakAuthenticatorSepc - authorizeWalletAccess - reject expired token
org.hyperledger.identus.iam.authentication.oidc.KeycloakAuthenticatorSpec ‑ KeycloakAuthenticatorSepc - authorizeWalletAccess - reject malformed token
org.hyperledger.identus.iam.authentication.oidc.KeycloakAuthenticatorSpec ‑ KeycloakAuthenticatorSepc - authorizeWalletAccess - reject token with a wallet that doesn't exist
org.hyperledger.identus.iam.authentication.oidc.KeycloakAuthenticatorSpec ‑ KeycloakAuthenticatorSepc - authorizeWalletAccess - reject token with multiple permitted wallets
org.hyperledger.identus.iam.authentication.oidc.KeycloakAuthenticatorSpec ‑ KeycloakAuthenticatorSepc - authorizeWalletAccess - reject token with no permitted wallet
…
org.hyperledger.identus.iam.authentication.oidc.KeycloakAuthenticatorSpec ‑  - authenticate - authenticate entity with multiple role not support
org.hyperledger.identus.iam.authentication.oidc.KeycloakAuthenticatorSpec ‑  - authenticate - authenticate entity with specified role
org.hyperledger.identus.iam.authentication.oidc.KeycloakAuthenticatorSpec ‑  - authenticate - authenticate entity with tenant role if not specified
org.hyperledger.identus.iam.authentication.oidc.KeycloakAuthenticatorSpec ‑  - authorizeWalletAccess - admin role is not authorized for wallet access
org.hyperledger.identus.iam.authentication.oidc.KeycloakAuthenticatorSpec ‑  - authorizeWalletAccess - allow token with a permitted wallet
org.hyperledger.identus.iam.authentication.oidc.KeycloakAuthenticatorSpec ‑  - authorizeWalletAccess - reject expired token
org.hyperledger.identus.iam.authentication.oidc.KeycloakAuthenticatorSpec ‑  - authorizeWalletAccess - reject malformed token
org.hyperledger.identus.iam.authentication.oidc.KeycloakAuthenticatorSpec ‑  - authorizeWalletAccess - reject token with a wallet that doesn't exist
org.hyperledger.identus.iam.authentication.oidc.KeycloakAuthenticatorSpec ‑  - authorizeWalletAccess - reject token with multiple permitted wallets
org.hyperledger.identus.iam.authentication.oidc.KeycloakAuthenticatorSpec ‑  - authorizeWalletAccess - reject token with no permitted wallet
…

@patlo-iog patlo-iog merged commit 9c79c7c into main Jul 1, 2024
17 checks passed
@patlo-iog patlo-iog deleted the prerelease/test branch July 1, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants