fix: subscriptions historical filtering #1674
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The
subscriptions/<id>/events
API is really useful to find all the events that match your subscription.Unfortunately there was an assumption made in the code when filtering for historical events that the subscription wouldn't have a protocol. Subscriptions always have a protocol. It then set it to Websocket but there are some options that are valid for Webhooks and not Websocket so the validation would fail.
There is no need to set a default protocol, just use the one given.
Types of changes
Please make sure to follow these points