Skip to content

chore: make function comment match function name #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: make function comment match function name #1659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/data/data_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ func (dm *dataManager) getValidatorForDatatype(ctx context.Context, validator co
return v, err
}

// GetMessageWithData performs a cached lookup of a message with all of the associated data.
// GetMessageWithDataCached performs a cached lookup of a message with all of the associated data.
// - Use this in performance sensitive code, but note mutable fields like the status of the
// message CANNOT be relied upon (due to the caching).
func (dm *dataManager) GetMessageWithDataCached(ctx context.Context, msgID *fftypes.UUID, options ...CacheReadOption) (msg *core.Message, data core.DataArray, foundAllData bool, err error) {
Expand All @@ -201,7 +201,7 @@ func (dm *dataManager) GetMessageWithDataCached(ctx context.Context, msgID *ffty
return msg, data, foundAllData, err
}

// GetMessageData looks for all the data attached to the message, including caching.
// GetMessageDataCached looks for all the data attached to the message, including caching.
// It only returns persistence errors.
// For all cases where the data is not found (or the hashes mismatch)
func (dm *dataManager) GetMessageDataCached(ctx context.Context, msg *core.Message, options ...CacheReadOption) (data core.DataArray, foundAll bool, err error) {
Expand Down
2 changes: 1 addition & 1 deletion internal/operations/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ type operationsManager struct {
cache cache.CInterface
}

// SubmitBulkOperationUpdate implements Manager.
// SubmitBulkOperationUpdates implements Manager.
func (om *operationsManager) SubmitBulkOperationUpdates(ctx context.Context, updates []*core.OperationUpdate) error {
for _, update := range updates {
errString := ""
Expand Down