-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull_request template #1604
Merged
EnriqueL8
merged 2 commits into
hyperledger:main
from
alex-semenyuk:pull_request_template
Dec 5, 2024
+46
−0
Merged
Pull_request template #1604
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
<!-- Thanks for sending a pull request! --> | ||
|
||
## Proposed changes | ||
|
||
Please include a summary of the changes here and why we need those changes. And also let us know which issue is fixed. | ||
|
||
Fixes # <issue_number_here> | ||
|
||
<hr> | ||
|
||
## Types of changes | ||
|
||
<!-- to mark a point done, place an x in square brackets. eg [x]--> | ||
<!-- - [x] done with this task--> | ||
<!----Please delete options that are not relevant. And in order to tick the check box just but x inside them for example [x] like this-----> | ||
|
||
- [ ] Bug fix | ||
- [ ] New feature added | ||
- [ ] Documentation Update | ||
|
||
<hr> | ||
|
||
## Please make sure to follow these points | ||
|
||
<!-- to mark a point done, place an x in square brackets. eg [x]--> | ||
<!-- - [x] done with this task--> | ||
<!----Please delete options that are not relevant. And in order to tick the check box just but x inside them for example [x] like this-----> | ||
|
||
- [ ] I have read the contributing guidelines. | ||
- [ ] I have performed a self-review of my own code or work. | ||
- [ ] I have commented my code, particularly in hard-to-understand areas. | ||
- [ ] My changes generates no new warnings. | ||
- [ ] My Pull Request title is in format <code>< issue name ></code> eg <code>Added links in the documentation</code>. | ||
- [ ] I have added tests that prove my fix is effective or that my feature works. | ||
- [ ] My changes have sufficient code coverage (unit, integration, e2e tests). | ||
|
||
<hr> | ||
|
||
## Screenshots (If Applicable) | ||
|
||
<hr> | ||
|
||
|
||
## Other Information | ||
|
||
Any message for the reviewer or kick off the discussion by explaining why you considered this particular solution, any alternatives etc. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a checkbox about code coverage here please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added