Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore release candidate tags when determining latest tag for docs #1588

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Ignore release candidate tags when determining latest tag for docs #1588

merged 1 commit into from
Oct 3, 2024

Conversation

EnriqueL8
Copy link
Contributor

@EnriqueL8 EnriqueL8 commented Oct 3, 2024 •
edited
Loading

The latests docs release picked up the wrong tag because it took into consideration release candidate versions... https://github.com/hyperledger/firefly/actions/runs/11163270495/job/31029806304

grep -v removes lines with rc in them

@EnriqueL8 EnriqueL8 requested a review from a team as a code owner October 3, 2024 14:56
@EnriqueL8 EnriqueL8 mentioned this pull request Oct 3, 2024
Merged
peterbroadhurst
peterbroadhurst approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clear write ups on these 👍

@peterbroadhurst peterbroadhurst merged commit 1939b67 into main Oct 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbroadhurst peterbroadhurst peterbroadhurst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EnriqueL8 @peterbroadhurst