-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document support in v1.3.2 for large JSON numbers #1577
Conversation
Signed-off-by: Matthew Whitehead <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1577 +/- ##
===========================================
- Coverage 100.00% 99.75% -0.25%
===========================================
Files 325 338 +13
Lines 24055 24223 +168
===========================================
+ Hits 24055 24164 +109
- Misses 0 58 +58
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. |
## Maximum size of numbers in versions of FireFly up to `v1.3.1` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I wouldn't only had this section in the ffbigint description as it's quite nested down in the documentation under reference. We need to document this in two other places:
- Doc around invoking a smart contract through the API
- Release notes for v1.3.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking something in the interface format https://hyperledger.github.io/firefly/latest/reference/firefly_interface_format/#schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example you can see in the simple invoke EVM contract tutorial we use a number https://hyperledger.github.io/firefly/latest/tutorials/custom_contracts/ethereum/#invoke-the-smart-contract
Signed-off-by: Matthew Whitehead <[email protected]>
Signed-off-by: Matthew Whitehead <[email protected]>
doc-site/docs/releasenotes/index.md
Outdated
- Support for JSON numbers larger than `2^53-1` | ||
See [FFBigInt](../reference/types/simpletypes.md#ffbigint) | ||
- Ability to install FireFly CLI with Brew for MacOS users | ||
See [Brew](../) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing the link here to brew
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bah, my bad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think that's gated on #1572 merging? Assuming that PR merges as-is, the latest commit should be correct for the new brew docs
Signed-off-by: Matthew Whitehead <[email protected]>
LGTM - Will fix codecov in a follow up PR |
See issue #1568
This PR documents the new large-number support. For convenience, here's a preview of the updated topic: