Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map example to Tezos docs #1468

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

alex-semenyuk
Copy link
Member

No description provided.

Signed-off-by: alexey semenyuk <[email protected]>
@alex-semenyuk alex-semenyuk requested a review from a team as a code owner February 15, 2024 21:01
@alex-semenyuk
Copy link
Member Author

Test is failed unrelated to this PR

download_manager_test.go:314: FAIL:	SubmitOperationUpdate(string)
        		at: [/home/runner/work/firefly/firefly/internal/shareddownload/download_manager_test.go:299]
    download_manager_test.go:314: FAIL: 3 out of 4 expectation(s) were met.
        	The code you are testing needs to make 1 more call(s).
        	at: [/home/runner/work/firefly/firefly/internal/shareddownload/download_manager_test.go:314]
--- FAIL: TestDownloadManagerStartupRecoveryCombinations (0.00s)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b1fd7dc) 99.99% compared to head (a627551) 99.99%.
Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1468   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files         322      322           
  Lines       23301    23300    -1     
=======================================
- Hits        23299    23298    -1     
  Misses          1        1           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nguyer
Copy link
Contributor

nguyer commented Feb 16, 2024

Looks like the failed unit test is intermittent and completely unrelated to these changes. Sorry about that. I've opened #1469 to track the fact that we need to fix that test.

@nguyer nguyer merged commit 8b6b604 into hyperledger:main Feb 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants