chore: start upgrade to firefly-common 1.4.1 #1440
Conversation
Signed-off-by: SamMayWork <[email protected]>
SamMayWork
force-pushed
the
firefly-common-upgrade
branch
from
235a713 to
73b71b1
Compare
Signed-off-by: SamMayWork <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1440 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 321 321
Lines 23105 23105
=======================================
Hits 23103 23103
Misses 1 1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
This is great, thank you! I have one request for a related change. Could you please also update the GitHub workflows to use go "1.21" as well? It's probably also worth checking that we're using the latest versions of actions (like checkout v4) in our workflows too. Thanks!
| @@ -1,7 +1,7 @@ | |||
| go 1.18 | |||
| go 1.21 | |||
There was a problem hiding this comment.
Noting that this is a big jump. I think it's the right time to do it, but it will also be worth calling out to the rest of the community that we require Go v1.21 or newer now.
There was a problem hiding this comment.
Should be addressed by ac44d47. The changes to make FireFly use 1.21 consistently are more far reaching than just the workflows so have updated those places.
The new images in the commit come from both the golang and alpine image listings:
Signed-off-by: SamMayWork <[email protected]>
|
Looking at the build failures 👀 |
Signed-off-by: Nicko Guyer <[email protected]>
Signed-off-by: Nicko Guyer <[email protected]>
Signed-off-by: SamMayWork <[email protected]>
…k/firefly into firefly-common-upgrade
Begin upgrade of FireFly to the latest version of FireFly common