Increase test coverage and code cleanup #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Semenyuk <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
===========================================
+ Coverage 51.33% 62.92% +11.59%
===========================================
Files 22 22
Lines 861 847 -14
===========================================
+ Hits 442 533 +91
+ Misses 415 310 -105
Partials 4 4 ☔ View full report in Codecov by Sentry. |
alex-semenyuk
changed the title
alex-semenyuk
commented
Nov 23, 2023
| @@ -409,12 +409,3 @@ func (bl *blockListener) getHighestBlock(ctx context.Context) int64 { | |||
| log.L(ctx).Debugf("ChainHead=%d", highestBlock) | |||
| return highestBlock | |||
| } | |||
|
|
|||
| func (bl *blockListener) waitClosed() { | |||
There was a problem hiding this comment.
This code is used only from test and can be omitted there, so let's remove it
denisandreenko
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.