Increase code coverage #24
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 47.85% 51.33% +3.48%
==========================================
Files 22 22
Lines 861 861
==========================================
+ Hits 412 442 +30
+ Misses 444 415 -29
+ Partials 5 4 -1 ☔ View full report in Codecov by Sentry. |
| @@ -5,8 +5,6 @@ on: | |||
| branches: [main] | |||
| pull_request: | |||
| branches: [main] | |||
| pull_request_target: | |||
There was a problem hiding this comment.
Removed this that it seems it's intermittent issue with uploading codecov report which doesn't depend on when running workflow on pull_request or pull_request_target:
{'detail': ErrorDetail(string='Repository slug or commit sha do not match Github actions build. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
It's solved by running workflow few time
cmd/version.go
Outdated
| // When we're in go-releaser in a Github action, we will have the version passed in explicitly | ||
| if info.Version == "" { | ||
| buildInfo, ok := debug.ReadBuildInfo() | ||
| setBuildInfo(info, buildInfo, ok) | ||
| } | ||
|
|
||
| if shortened { | ||
| fmt.Println(info.Version) | ||
| log.L(ctx).Infof("Build info: %s", info.Version) |
There was a problem hiding this comment.
I'm not sure that we'll get the version in this case, using CLI.
Will this info be printed in terminal, but not in the log file?
Signed-off-by: Alexey Semenyuk <[email protected]>
No description provided.