Added priv_call functionality to generated contract APIs #236
Conversation
niklas-emmelius-mittelstand-ai
commented
Sep 2, 2023
niklas-emmelius-mittelstand-ai
commented
- Retain PrivacyGroupID together with other private transaction fields
- Switch to priv_call when PrivacyGroupID is passed as query option
- No PrivacyGroupID generation from PrivateFrom and PrivateFor
niklas-emmelius-mittelstand-ai
requested review from
peterbroadhurst,
vdamle,
jimthematrix and
awrichar
as code owners
- Retain PrivacyGroupID together with other private transaction fields - Switch to priv_call when PrivacyGroupID is passed as query option - No PrivacyGroupID generation from PrivateFrom and PrivateFor Signed-off-by: Niklas Emmelius <[email protected]>
niklas-emmelius-mittelstand-ai
force-pushed
the
priv_call
branch
from
9c50163
to
4e6bc28
Compare
Codecov Report
@@ Coverage Diff @@
## main #236 +/- ##
==========================================
- Coverage 97.26% 97.18% -0.08%
==========================================
Files 59 59
Lines 7521 7529 +8
==========================================
+ Hits 7315 7317 +2
- Misses 163 167 +4
- Partials 43 45 +2 |
There was a problem hiding this comment.
Thanks @niklas-emmelius-mittelstand-ai for contributing this! I'm happy to merge it. Could you please add a unit test that covers the new code? As is, these changes reduce code coverage and we try to make sure it always goes up. Thanks!
- Test calls function callAndProcessReply - A privacyGroupId is passed in transaction - Captured rpc method should equal priv_call - Captured rpc args[0] should equal privacyGroupId Signed-off-by: Niklas Emmelius <[email protected]>
|
Hi, @nguyer I added a test for the changes. Hopefully coverage should now be unchanged. Let me know if there is anything else to do. |
| @@ -23,6 +23,7 @@ import ( | |||
| "reflect" | |||
| "testing" | |||
|
|
|||
| "github.com/ethereum/go-ethereum/common/hexutil" | |||
There was a problem hiding this comment.
Due to the licensing of the github.com/ethereum/go-ethereum we cannot depend on it in any code in this repo.
| assert.Equal(t, "HvuYiHoyL31rZ5OYRzSYMGGRV+V8KS4LMuHRfmfDWzg=", rpc.capturedArgs[0]) | ||
| assert.Equal(t, &SendTXArgs{ | ||
| From: "0x0000000000000000000000000000000000000000", | ||
| Data: &hexutil.Bytes{90, 238, 148, 49}, |
There was a problem hiding this comment.
I think you should be able to change this to ðbinding.HexBytes and have it work, which will remove the need to pull in github.com/ethereum/go-ethereum
|
Closing this PR due to inactivity. Please feel free to re-open if this work is still ongoing. |
