-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Get executable name from the command #326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are missing a few such as ff start
message after an ff init
Signed-off-by: dwertent <[email protected]>
@@ -53,7 +56,7 @@ func GetFireflyASCIIArt() string { | |||
|
|||
// rootCmd represents the base command when called without any subcommands | |||
var rootCmd = &cobra.Command{ | |||
Use: "ff", | |||
Use: ExecutableName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really need to make this usage message better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not part of this PR
I think the build failed due to a failure in the coverage report generation, maybe we should re-run the build job (it passed last time and the only change I made was the var name) |
I reran it and it's still failing |
I'm quite puzzled about why we are getting a broken pipe, might some related to etcd-io/etcd#17560 or the permission in the workflow |
This is ready to go :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - Thanks!
This PR enhances the FireFly CLI by making the executable name dynamic in the help messages. Instead of hardcoding the executable name, it is now loaded from the command-line arguments, allowing for dynamic help messages that reflect the actual executable name being used.
Before:
After: