more geth and besu unit tests

Signed-off-by: Philip-21 <[email protected]>
hyperledger · Dec 31, 2023 · 4abec60 · 4abec60
1 parent 375c811
commit 4abec60
Show file tree

Hide file tree

Showing 2 changed files with 134 additions and 0 deletions.
diff --git a/internal/blockchain/ethereum/besu/genesis_test.go b/internal/blockchain/ethereum/besu/genesis_test.go
@@ -7,6 +7,8 @@ import (
 	"strings"
 	"testing"
 
+	"github.com/hyperledger/firefly-cli/internal/blockchain/ethereum"
+	"github.com/hyperledger/firefly-cli/pkg/types"
 	"github.com/stretchr/testify/assert"
 )
 
@@ -143,3 +145,43 @@ func TestWriteGenesisJSON(t *testing.T) {
 	}
 
 }
+
+func TestGetConnectorExternal(t *testing.T) {
+	testcase := []struct {
+		Name         string
+		Org          *types.Organization
+		ExpectedPort string
+	}{
+		{
+			Name: "testcase1",
+			Org: &types.Organization{
+				OrgName:  "Org-1",
+				NodeName: "besu",
+				Account: &ethereum.Account{
+					Address:    "0x1f2a000000000000000000000000000000000000",
+					PrivateKey: "9876543210987654321098765432109876543210987654321098765432109876",
+				},
+				ExposedConnectorPort: 8584,
+			},
+			ExpectedPort: "http://127.0.0.1:8584",
+		},
+		{
+			Name: "testcase2",
+			Org: &types.Organization{
+				OrgName:  "Org-2",
+				NodeName: "besu",
+				Account: &ethereum.Account{
+					Address:    "0xabcdeffedcba9876543210abcdeffedc00000000",
+					PrivateKey: "aabbccddeeff0011223344556677889900112233445566778899aabbccddeeff",
+				},
+				ExposedConnectorPort: 8000,
+			},
+			ExpectedPort: "http://127.0.0.1:8000",
+		},
+	}
+	for _, tc := range testcase {
+		p := &BesuProvider{}
+		result := p.GetConnectorExternalURL(tc.Org)
+		assert.Equal(t, tc.ExpectedPort, result)
+	}
+}
diff --git a/internal/blockchain/ethereum/geth/geth_provider_test.go b/internal/blockchain/ethereum/geth/geth_provider_test.go
@@ -2,6 +2,7 @@ package geth
 
 import (
 	"context"
+	"encoding/hex"
 	"os"
 	"path/filepath"
 
@@ -242,3 +243,94 @@ func CompareStringSlices(a, b []string) bool {
 	}
 	return true
 }
+
+func TestGetConnectorExternal(t *testing.T) {
+	testcase := []struct {
+		Name         string
+		Org          *types.Organization
+		ExpectedPort string
+	}{
+		{
+			Name: "testcase1",
+			Org: &types.Organization{
+				OrgName:  "Org-1",
+				NodeName: "geth",
+				Account: &ethereum.Account{
+					Address:    "0x1f2a000000000000000000000000000000000000",
+					PrivateKey: "9876543210987654321098765432109876543210987654321098765432109876",
+				},
+				ExposedConnectorPort: 8584,
+			},
+			ExpectedPort: "http://127.0.0.1:8584",
+		},
+		{
+			Name: "testcase2",
+			Org: &types.Organization{
+				OrgName:  "Org-2",
+				NodeName: "geth",
+				Account: &ethereum.Account{
+					Address:    "0xabcdeffedcba9876543210abcdeffedc00000000",
+					PrivateKey: "aabbccddeeff0011223344556677889900112233445566778899aabbccddeeff",
+				},
+				ExposedConnectorPort: 8000,
+			},
+			ExpectedPort: "http://127.0.0.1:8000",
+		},
+	}
+	for _, tc := range testcase {
+		p := &GethProvider{}
+		result := p.GetConnectorExternalURL(tc.Org)
+		assert.Equal(t, tc.ExpectedPort, result)
+	}
+}
+
+func TestCreateAccount(t *testing.T) {
+	testcases := []struct {
+		Name  string
+		Stack *types.Stack
+		Args  []string
+	}{
+		{
+			Name: "testcase1",
+			Stack: &types.Stack{
+				Name:                   "Org-1_geth",
+				BlockchainProvider:     fftypes.FFEnumValue("BlockchainProvider", "Ethereum"),
+				BlockchainConnector:    fftypes.FFEnumValue("BlockChainConnector", "Ethconnect"),
+				BlockchainNodeProvider: fftypes.FFEnumValue("BlockchainNodeProvider", "geth"),
+			},
+			Args: []string{},
+		},
+		{
+			Name: "testcase1",
+			Stack: &types.Stack{
+				Name:                   "Org-2_geth",
+				BlockchainProvider:     fftypes.FFEnumValue("BlockchainProvider", "Ethereum"),
+				BlockchainConnector:    fftypes.FFEnumValue("BlockChainConnector", "Ethconnect"),
+				BlockchainNodeProvider: fftypes.FFEnumValue("BlockchainNodeProvider", "geth"),
+			},
+			Args: []string{},
+		},
+	}
+	for _, tc := range testcases {
+		t.Run(tc.Name, func(t *testing.T) {
+			p := &GethProvider{
+				stack: tc.Stack,
+			}
+			Account, err := p.CreateAccount(tc.Args)
+			if err != nil {
+				t.Log("unable to create account", err)
+			}
+			//validate properties of account
+			assert.NotNil(t, Account)
+			account, ok := Account.(*ethereum.Account)
+			assert.True(t, ok, "unexpected Type for account")
+
+			//check if Ethereum Addresss is valid
+			assert.NotEmpty(t, account.Address)
+			// Check if the private key is a non-empty hex string
+			assert.NotEmpty(t, account.PrivateKey)
+			_, err = hex.DecodeString(account.PrivateKey)
+			assert.NoError(t, err, "invalid private key format")
+		})
+	}
+}