Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prague Engine API validation fixes #8250

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

siladu
Copy link
Contributor

@siladu siladu commented Feb 5, 2025

To ensure we comply with these parts of the spec:

https://github.com/ethereum/execution-apis/blob/main/src/engine/cancun.md

For the following methods:
engine_forkchoiceUpdatedV2
engine_newPayloadV2
engine_getPayloadV2
a validation MUST be added:
Client software MUST return -38005: Unsupported fork error if the timestamp of payload or payloadAttributes greater or equal to the Cancun activation timestamp.

https://github.com/ethereum/execution-apis/blob/main/src/engine/prague.md

For the following methods:
engine_newPayloadV3
engine_getPayloadV3
a validation MUST be added:
Client software MUST return -38005: Unsupported fork error if the timestamp of payload greater or equal to the Prague activation timestamp.
For the engine_forkchoiceUpdatedV3 the following modification MUST be made:
Return -38005: Unsupported fork if payloadAttributes.timestamp doesn't fall within the time frame of the Cancun or Prague forks.

Note, I have not added FCUV3Test as part of this as it's a larger job which I'm deferring to #8252

Fixed Issue(s)

#8179

Testing

Feb 5 06:03:23.212 INF simulation ethereum/eest/consume-engine finished suites=1 tests=4306 failed=0

Also tested that it syncs with the live devnet-6

@siladu siladu changed the title Prague newPayload validation fixes Prague Engine API validation fixes Feb 5, 2025
@siladu siladu marked this pull request as ready for review February 5, 2025 06:10
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one q

@siladu siladu enabled auto-merge (squash) February 6, 2025 01:36
@siladu siladu merged commit 2680901 into hyperledger:main Feb 6, 2025
43 checks passed
@siladu siladu deleted the prague-engine-validation branch February 6, 2025 02:12
pullurib pushed a commit to pullurib/besu that referenced this pull request Feb 6, 2025
- Prague newPayload validation fixes
- Testing the unsupported fork timestamp cases

Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Bhanu Pulluri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants