Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add db reset for Ephemery network on restart #8213

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add db reset for Ephemery network on restart #8213

wants to merge 4 commits into from

Conversation

gconnect
Copy link
Contributor

@gconnect gconnect commented Jan 31, 2025 •
edited
Loading

PR description

Fixed Issue(s)

fixes #8180

  • Add additional note for Ephemery on Invalid Configuration Exception
  • Reset db when network updates

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@gconnect gconnect changed the title Add additional note for Ephemery on InvalidConfigurationException Add db reset for Ephemery network on restart Jan 31, 2025
@gconnect
Copy link
Contributor Author

@jflo @macfarla please review

macfarla
macfarla requested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gconnect can you figure out a way to test this locally, NETWORK is not what you think it is

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/chain/DefaultBlockchain.java
+ ".\n"
+ "Please specify a different data directory with --data-path, specify the original genesis file with "
+ "--genesis-file or supply a testnet/mainnet option with --network.");
if (NETWORK.getName().equals("Ephemery")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this NETWORK is a metrics category not the network name you're looking for

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also I'd use equalsIgnoreCase to allow variances

macfarla
macfarla requested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gconnect can you figure out a way to test this locally, NETWORK is not what you think it is

@macfarla macfarla marked this pull request as draft February 4, 2025 01:53
@gconnect
Copy link
Contributor Author

gconnect commented Feb 4, 2025

@gconnect can you figure out a way to test this locally, NETWORK is not what you think it is

Alright I will figure it out. Thanks for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add db reset for Ephemery network on restart
2 participants
@gconnect @macfarla