Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo Update Private-Txns-Migration.md #7874

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

onasilos
Copy link

PR description

I found a typo in the following part:

A critical issue for privacy users with private transactions created using Hyperledger Besu v1.3.4 or earlier has been identified. If you have a network with private transaction created using v1.3.4 or earlier, please read the following and take the appropriate steps:

The phrase "private transaction created" should be "private transactions created".

The corrected sentence:

A critical issue for privacy users with private transactions created using Hyperledger Besu v1.3.4 or earlier has been identified. If you have a network with private transactions created using v1.3.4 or earlier, please read the following and take the appropriate steps:

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

The phrase "private transaction created" should be "private transactions created".

Fixed.

Signed-off-by: onasilos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant