Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove synchronizer from protocol context #7863

Merged

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Nov 6, 2024

PR description

Followup to #7862, completes the removal of the Synchronizer from ProtocolContext thus making the latter an immutable object and simplifying its instantiation.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10 fab-10 force-pushed the remove-synchronizer-from-protocol-context branch 2 times, most recently from 02b0f04 to 918f9ce Compare November 8, 2024 14:12
@fab-10 fab-10 marked this pull request as ready for review November 8, 2024 14:12
@fab-10 fab-10 force-pushed the remove-synchronizer-from-protocol-context branch from 918f9ce to af66072 Compare November 8, 2024 14:16
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@fab-10 fab-10 enabled auto-merge (squash) November 8, 2024 14:31
@fab-10 fab-10 merged commit 1c75afb into hyperledger:main Nov 8, 2024
43 checks passed
@fab-10 fab-10 deleted the remove-synchronizer-from-protocol-context branch November 8, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants