Docker: Only switch user if the current user is root #7654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nning as root Signed-off-by: Rafael Matias <[email protected]>
fab-10
reviewed
Sep 20, 2024
| @@ -45,5 +45,10 @@ done | |||
| # Construct the command as a single string | |||
| COMMAND="/opt/besu/bin/besu $@" | |||
|
|
|||
| # Switch to the besu user and execute the command | |||
| exec su -s /bin/bash $BESU_USER_NAME -c "$COMMAND" | |||
| # Check if current user is root | |||
There was a problem hiding this comment.
Make sense, and probably if not root we can skip the all the part that fixes path permission, so I suggest to move this check at the very beginning of the script and if root just exec Besu, otherwise run the rest of the script, wdyt?
FYI @pullurib
There was a problem hiding this comment.
Yes, I agree, a check at very beginning of the script and if not root, just exec'ing Besu should be good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One might be running the container without root (e.g.
docker run --user youruser ...), if that's the case you'll get an error like this when runningsu: