Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading tx-pool-min-score option from configuration file #7623

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Sep 16, 2024

PR description

Follow up of #7576, to fix reading the new tx-pool-min-score option when specified in the configuration file

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10 fab-10 changed the title Fix reading tx-pool-min-score option from configuration file Fix reading tx-pool-min-score option from configuration file Sep 16, 2024
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fab-10 fab-10 enabled auto-merge (squash) September 20, 2024 10:20
@fab-10 fab-10 enabled auto-merge (squash) September 20, 2024 13:52
@fab-10 fab-10 enabled auto-merge (squash) September 20, 2024 14:34
@fab-10 fab-10 merged commit 3e0e5cd into hyperledger:main Sep 20, 2024
43 checks passed
@fab-10 fab-10 deleted the fix-tx-pool-min-score-config branch September 20, 2024 15:12
Wolmin pushed a commit to lukso-network/network-besu that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants