Issue 7273 geth style genesis #7609
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new classes for analyzing, converting, and validating Geth-style genesis files. Update existing classes to support the new functionality. This improves Besu's ability to work with Geth-compatible genesis files, enhancing interoperability. Key changes: - Add GenesisFileAnalyzer, GenesisFileConverter, GenesisFileValidator - Update GenesisConfigFile and GenesisReader for compatibility - Add tests for new functionality - Update build.gradle and verification-metadata.xml Signed-off-by: Ade Lucas <[email protected]>
Update GenesisFileHandlingTest and GenesisFileConverter to resolve test failures. This commit addresses issues that were causing tests to fail, improving the reliability of our test suite. Key changes: - Modify GenesisFileHandlingTest to correct failing assertions - Adjust GenesisFileConverter to align with expected test outcomes - Ensure consistency between test expectations and actual behavior Signed-off-by: Ade Lucas <[email protected]>
Remove debugging print statements Signed-off-by: Ade Lucas <[email protected]>
This commit introduces support for Geth-style genesis files in Besu: - Modified GenesisConfigFile, GenesisFileAnalyzer, GenesisFileConverter, and GenesisReader - Added new GenesisFileHandler - Removed GenesisFileValidator and GenesisFileAnalyzerTest - Updated GenesisFileHandlingTest This feature enhances Besu's compatibility with Geth genesis configurations. Signed-off-by: Ade Lucas <[email protected]>
Added entry for Geth-style genesis file support in the Features section. Signed-off-by: Ade Lucas <[email protected]>
Update the gradle/verification-metadata.xml file to reflect recent dependency changes and ensure consistent builds across environments. Signed-off-by: Ade Lucas <[email protected]>
cloudspores
force-pushed
the
issue-7273-geth-style-genesis
branch
from
8705722
to
726312c
Compare
Signed-off-by: Ade Lucas <[email protected]>
This commit updates a comment This feature enhances Besu's compatibility with Geth genesis configurations. Signed-off-by: Ade Lucas <[email protected]>
This commit addresses bugs in GenesisFileAnalyzer and GenesisFileHandler related to the normalization of genesis file field names. The fixes ensure correct handling of field names across different genesis file formats. - Updated GenesisFileAnalyzer to properly normalize field names - Corrected field name handling in GenesisFileHandler - Updated related tests in GenesisFileHandlingTest Signed-off-by: Ade Lucas <[email protected]>
This commit addresses four ambiguous testcases. - Removed related tests in GenesisFileHandlingTest Signed-off-by: Ade Lucas <[email protected]>
Signed-off-by: Ade Lucas <[email protected]>
fab-10
requested changes
Sep 19, 2024
There was a problem hiding this comment.
Overall looks good, there are some minor things to remove or change.
For the tests, I suggest to add also some real world geth genesis files, for example from the current Pectra devnets, where genesis.json is in geth format and besu.json is in Besu
config/src/main/java/org/hyperledger/besu/config/GenesisFileAnalyzer.java
Outdated
Show resolved
Hide resolved
…er handling of extraData. Added testcases for official genesis files. Signed-off-by: Ade Lucas <[email protected]>
fab-10
reviewed
Sep 23, 2024
There was a problem hiding this comment.
Nice to have the test against real world genesis files.
Before approving I would like to understand potential performance penalty of the extra parsing, see my comment #7273 (comment)
Signed-off-by: Ade Lucas <[email protected]>
- Updated build.gradle to remove tuweni 2.3.1 refrences. Signed-off-by: Ade Lucas <[email protected]>
fab-10
reviewed
Sep 24, 2024
There was a problem hiding this comment.
LGTM
Before approving I would like to understand potential performance penalty of the extra parsing, see my comment #7273 (comment)
|
This pr is stale because it has been open for 30 days with no activity. |
|
I can take care of this one, evaluating the performance impact |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
Fixes #7273
Allowing Besu to parse a Geth-style genesis like other clients, so interoperability testing and multi-client network operation is simpler.
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests