Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync performance improvements #7595

Closed
wants to merge 10 commits into from

Conversation

ahamlat
Copy link
Contributor

@ahamlat ahamlat commented Sep 10, 2024

PR description

This PR is a different implementation of this old one #5679. It has exactly the same goal, i.e avoid validating twice transactionsRoot and receiptsRoot during sync.

CPU profiling

Before this PR

image

With this PR
image

Fixed Issue(s)

#7581

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@ahamlat ahamlat changed the title Avoid validating twice transactionsRoot and receiptsRoot during sync Sync performance improvements Sep 11, 2024
@ahamlat
Copy link
Contributor Author

ahamlat commented Oct 28, 2024

The same improvement was implemented in this PR #7646

@ahamlat ahamlat closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant