Add network support for ephemery testnet #7471

gconnect · 2024-08-16T02:36:21Z

PR description

Fixed Issue(s)

Add Ephemery genesis file to the resources
Add Ephemery network to NetworkName
Add test for Ephemery to BesuCommandTest
Add Ephemery to NetworkDeprecationTest file
Add Ephemery genesis function to automatically generate a new genesis file in line with the spec requirements for Ephermery Testnet
Add test for the genesis generation function

This PR is in response to this issue 7404

@non-fungible-nelson please review when you have some time.

Thanks for sending a pull request! Have you done the following?

Checked out our contribution guidelines?
Considered documentation and added the doc-change-required label to this PR if updates are required.
Considered the changelog and included an update if required.
For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

unit tests: ./gradlew build
acceptance tests: ./gradlew acceptanceTest
integration tests: ./gradlew integrationTest
reference tests: ./gradlew ethereum:referenceTests:referenceTests

besu/src/main/java/org/hyperledger/besu/cli/config/NetworkName.java

besu/src/test/java/org/hyperledger/besu/cli/BesuCommandTest.java

temp-ephemery.json

evm/src/test/java/org/hyperledger/besu/evm/operation/Create2OperationTest.java

besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java

macfarla · 2024-08-21T01:30:11Z

@gconnect is this still WIP as the title suggests, or ready for review?

gconnect · 2024-08-21T01:40:10Z

@gconnect is this still WIP as the title suggests, or ready for review?

Yes @macfarla it is. Currently working on the requested changed. I have made most of the changes what is left is the test. Should be done with it later today and push update then remove the WIP.

Also a quick one, I created the standalone class under the utils directory am not sure if it's okay there.

gconnect · 2024-08-23T05:32:33Z

@gconnect is this still WIP as the title suggests, or ready for review?

@macfarla is ready for review. Thank you.

besu/src/main/java/org/hyperledger/besu/cli/config/NetworkName.java

besu/src/main/java/org/hyperledger/besu/util/GenerateEphemeryGenesisFile.java

besu/src/main/java/org/hyperledger/besu/cli/config/NetworkName.java

besu/src/main/java/org/hyperledger/besu/util/GenerateEphemeryGenesisFile.java

) * exclude permissioning test from default ATs run on PRs Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: gconnect <[email protected]>

Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: gconnect <[email protected]>

… trace (hyperledger#7336) * eliminate non-constant string concatenation from debug and trace Signed-off-by: Sally MacFarlane <[email protected]> * adjustments Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: gconnect <[email protected]>

Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: gconnect <[email protected]>

--------- Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: gconnect <[email protected]>

…perledger#7296) Optimistic transaction parallelization execution during block processing to improve the performances. This feature can enabled with a flag --Xbonsai-parallel-tx-processing-enabled=true Signed-off-by: Karim Taam <[email protected]> Co-authored-by: Ameziane H <[email protected]> Co-authored-by: garyschulte <[email protected]> Signed-off-by: gconnect <[email protected]>

…7353) * 7732: Remove datagas related stuff in favour of blobgas Signed-off-by: Matilda Clerke <[email protected]> --------- Signed-off-by: Matilda Clerke <[email protected]> Signed-off-by: gconnect <[email protected]>

Fix NPE for legacy ForkId with no forks Signed-off-by: [email protected] <[email protected]> Signed-off-by: gconnect <[email protected]>

…resh, not just the first one (hyperledger#7314) * Add new config option to use bootnodes during any peer table refresh, not just the first one Signed-off-by: Matthew Whitehead <[email protected]> * Update everything-config list Signed-off-by: Matthew Whitehead <[email protected]> * Revert debug setting Signed-off-by: Matthew Whitehead <[email protected]> * Update ethereum/p2p/src/main/java/org/hyperledger/besu/ethereum/p2p/discovery/internal/PeerDiscoveryController.java Co-authored-by: Stefan Pingel <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Signed-off-by: gconnect <[email protected]>

This avoids executing TrieLogPruner.preload Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: gconnect <[email protected]>

Add unit tests to the EXTCODE* series operations. Also, put all EVM operations tests in the proper package. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: gconnect <[email protected]>

Signed-off-by: gconnect <[email protected]>

…ction pool (hyperledger#7359) * Introduce score for pending transactions Signed-off-by: Fabio Di Fabio <[email protected]> * Introduce score for pending transactions Signed-off-by: Fabio Di Fabio <[email protected]> * Update package javadoc Signed-off-by: Fabio Di Fabio <[email protected]> --------- Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: gconnect <[email protected]>

…yperledger#7377) * Update GeneralStateTestCaseEipSpec for use in linea-arithmetization Signed-off-by: Gaurav Ahuja <[email protected]> * formatting Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Gaurav Ahuja <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: gconnect <[email protected]>

…act (hyperledger#7380) Signed-off-by: garyschulte <[email protected]> Signed-off-by: gconnect <[email protected]>

…#7357) There is still a startup error when bonsai-limit-trie-logs-enabled is explicitly set to true --------- Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: gconnect <[email protected]>

* Do not maintain connections to bootnodes Signed-off-by: Matthew Whitehead <[email protected]> * Update changelog entry Signed-off-by: Matthew Whitehead <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Signed-off-by: gconnect <[email protected]>

Also reduce pruning window from 30_000 to 5_000 --------- Signed-off-by: Simon Dudley <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: gconnect <[email protected]>

…exist (hyperledger#7305) Signed-off-by: Jason Frame <[email protected]> Signed-off-by: gconnect <[email protected]>

…Info is null (hyperledger#7508) Signed-off-by: kesrishubham2510 <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: gconnect <[email protected]>

Signed-off-by: Neo <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: gconnect <[email protected]>

…er#7517) * fleet-mode safe behavior for fcU in SynchronizationService Signed-off-by: garyschulte <[email protected]> * spotless Signed-off-by: garyschulte <[email protected]> --------- Signed-off-by: garyschulte <[email protected]> Signed-off-by: gconnect <[email protected]>

* EVMTool should respect --genesis option Update the code so that the genesis file option will be respected when set. Also, default --fork options should set a rational base fee. Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: gconnect <[email protected]>

The fuzzAll task depended on targets that didn't exist. Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: gconnect <[email protected]>

* Release checklist update More details on homebrew and docs releases in release checklist issue template Co-authored-by: Simon Dudley <[email protected]> Signed-off-by: Chaminda Divitotawela <[email protected]> * Remove release creation for besu-docs from checklist It has been agreed there is no value creating releases in the hyperledger/besu-docs repo. Remove the related instruction from checklist Signed-off-by: Chaminda Divitotawela <[email protected]> --------- Signed-off-by: Chaminda Divitotawela <[email protected]> Signed-off-by: Chaminda Divitotawela <[email protected]> Co-authored-by: Simon Dudley <[email protected]> Signed-off-by: gconnect <[email protected]>

Signed-off-by: gconnect <[email protected]>

Signed-off-by: Glory Agatevure <[email protected]>

gconnect · 2024-08-26T13:41:28Z

@macfarla I have made the requested changes.

… test Signed-off-by: gconnect <[email protected]>

Signed-off-by: gconnect <[email protected]>

gconnect · 2024-08-28T22:57:29Z

@macfarla I have made the requested changes and added the update changelog.md file

macfarla

it's coming together! a few more comments

besu/src/main/java/org/hyperledger/besu/cli/config/NetworkName.java

besu/src/main/java/org/hyperledger/besu/util/EphemeryGenesisFile.java

besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java

besu/src/main/java/org/hyperledger/besu/util/EphemeryGenesisFile.java

macfarla · 2024-08-29T04:53:44Z

besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java

+      ephemeryGenesisFile =
+          new EphemeryGenesisFile(readGenesisConfigFile(), readGenesisConfigOptions());
+      ephemeryGenesisFile.updateGenesis();
+    }


I actually think lines 1096 - 1100 should be part of readGenesisConfigFile() so that calling readGenesisConfigFile will always give you the effective genesis file, and then maybe you don't need to modify the EPHEMERY networkName object itself.

Moving the code to this readGenesisConfigFile() resulted in a recursive error. I placed the code where it is now because I want the check to happen on client start

Signed-off-by: gconnect <[email protected]>

gconnect · 2024-09-03T04:56:12Z

@macfarla I am closing the PR. I opened a new PR here

gconnect · 2024-09-03T04:56:42Z

@macfarla I am closing the PR. I opened a new PR #7563

gconnect force-pushed the add-network-support-for-ephemery-testnet branch from 3f6b682 to f58f4e0 Compare August 17, 2024 21:59

macfarla reviewed Aug 19, 2024

View reviewed changes

gconnect changed the title ~~[WIP] Add network support for ephemery testnet~~ Add network support for ephemery testnet Aug 23, 2024

macfarla reviewed Aug 26, 2024

View reviewed changes

macfarla and others added 23 commits August 26, 2024 13:47

[minor] Remove redundant info from plugin summary (hyperledger#7339)

62cee8a

Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: gconnect <[email protected]>

Update release checklist (hyperledger#7329)

ba98608

Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: gconnect <[email protected]>

Add metrics for trie log pruner (hyperledger#7352)

e85dd37

--------- Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: gconnect <[email protected]>

Fix NPE for legacy ForkId with no forks (hyperledger#7349)

3d7ad16

Fix NPE for legacy ForkId with no forks Signed-off-by: [email protected] <[email protected]> Signed-off-by: gconnect <[email protected]>

Disable limit trie logs for trie log subcommand (hyperledger#7366)

4b31e6e

This avoids executing TrieLogPruner.preload Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: gconnect <[email protected]>

Add EXTCODE* unit Tests (hyperledger#7374)

d5f0364

Add unit tests to the EXTCODE* series operations. Also, put all EVM operations tests in the proper package. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: gconnect <[email protected]>

add option for ephemery testnet

260b8f6

Signed-off-by: gconnect <[email protected]>

add ephemery bootnodes to the ephemery.json genesis file

05da951

Signed-off-by: gconnect <[email protected]>

Add test for ephemery

dd3ab09

Signed-off-by: gconnect <[email protected]>

Format code with sportlessApply

4d678a4

Signed-off-by: gconnect <[email protected]>

Add setNetworkId method and generateEphemeryGenesis

9e875ec

Signed-off-by: gconnect <[email protected]>

bump execution-spec-tests, account for new name for main stable artif…

4c4b60a

…act (hyperledger#7380) Signed-off-by: garyschulte <[email protected]> Signed-off-by: gconnect <[email protected]>

Disable bonsai-limit-trie-logs-enabled if sync-mode=FULL (hyperledger…

edace71

…#7357) There is still a startup error when bonsai-limit-trie-logs-enabled is explicitly set to true --------- Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: gconnect <[email protected]>

TrieLogPruner preload with 30 second timeout (hyperledger#7365)

5c82a3f

Also reduce pruning window from 30_000 to 5_000 --------- Signed-off-by: Simon Dudley <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: gconnect <[email protected]>

Snap server GetTrieNodes to return empty bytes when trienode doesn't …

5521cb8

…exist (hyperledger#7305) Signed-off-by: Jason Frame <[email protected]> Signed-off-by: gconnect <[email protected]>

kesrishubham2510 and others added 7 commits August 26, 2024 13:47

Fixed | Initialising the encodedPubKey with empty String in case user…

aa13cda

…Info is null (hyperledger#7508) Signed-off-by: kesrishubham2510 <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: gconnect <[email protected]>

update link (hyperledger#7506)

c0d237d

Signed-off-by: Neo <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: gconnect <[email protected]>

Fix fuzzing dependencies (hyperledger#7519)

c3b47b0

The fuzzAll task depended on targets that didn't exist. Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: gconnect <[email protected]>

Format the NetworkName file and update the Ephemery comment

ef55bed

Signed-off-by: gconnect <[email protected]>

gconnect force-pushed the add-network-support-for-ephemery-testnet branch from 4a45494 to ef55bed Compare August 26, 2024 12:48

Merge branch 'main' into add-network-support-for-ephemery-testnet

58aa97c

Signed-off-by: Glory Agatevure <[email protected]>

gconnect added 4 commits August 27, 2024 14:17

Merge branch 'main' into add-network-support-for-ephemery-testnet

3dfadc6

Use genesisConfig overrides in the EphemeryGenesisFile and update the…

0a06caf

… test Signed-off-by: gconnect <[email protected]>

Merge main into branch

d5a29f1

Signed-off-by: gconnect <[email protected]>

Merge branch 'main' into add-network-support-for-ephemery-testnet

254f9ab

macfarla reviewed Aug 29, 2024

View reviewed changes

gconnect added 4 commits August 29, 2024 16:10

Merge branch 'main' into add-network-support-for-ephemery-testnet

e87b0c9

Update setNetworkId method, EphemeryGenesisFile and Update the test

16a3e76

Signed-off-by: gconnect <[email protected]>

Remove check for genesisconfigfile

7cee24a

Merge main into branch

2027ff1

Signed-off-by: gconnect <[email protected]>

gconnect force-pushed the add-network-support-for-ephemery-testnet branch from 36e1ce1 to 2027ff1 Compare August 30, 2024 05:12

gconnect added 6 commits August 30, 2024 06:13

Merge branch 'main' into add-network-support-for-ephemery-testnet

3c1290b

Merge branch 'main' into add-network-support-for-ephemery-testnet

28119c6

sign-off for commit 7cee24a

69c1b83

Signed-off-by: gconnect <[email protected]>

Merge main intro branch

1cc3ad3

Signed-off-by: gconnect <[email protected]>

Add comment to EphemeryGenesisFile

a53b92b

Signed-off-by: gconnect <[email protected]>

Merge branch 'main' into add-network-support-for-ephemery-testnet

f45e8c4

gconnect closed this Sep 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add network support for ephemery testnet #7471

Add network support for ephemery testnet #7471

gconnect commented Aug 16, 2024 •

edited by macfarla

Loading

macfarla commented Aug 21, 2024

gconnect commented Aug 21, 2024 •

edited

Loading

gconnect commented Aug 23, 2024

gconnect commented Aug 26, 2024

gconnect commented Aug 28, 2024 •

edited

Loading

macfarla left a comment

macfarla Aug 29, 2024

gconnect Aug 30, 2024

gconnect commented Sep 3, 2024

gconnect commented Sep 3, 2024

Add network support for ephemery testnet #7471

Add network support for ephemery testnet #7471

Conversation

gconnect commented Aug 16, 2024 • edited by macfarla Loading

PR description

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

Locally, you can run these tests to catch failures early:

macfarla commented Aug 21, 2024

gconnect commented Aug 21, 2024 • edited Loading

gconnect commented Aug 23, 2024

gconnect commented Aug 26, 2024

gconnect commented Aug 28, 2024 • edited Loading

macfarla left a comment

Choose a reason for hiding this comment

macfarla Aug 29, 2024

Choose a reason for hiding this comment

gconnect Aug 30, 2024

Choose a reason for hiding this comment

gconnect commented Sep 3, 2024

gconnect commented Sep 3, 2024

gconnect commented Aug 16, 2024 •

edited by macfarla

Loading

gconnect commented Aug 21, 2024 •

edited

Loading

gconnect commented Aug 28, 2024 •

edited

Loading