Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid doing multiple validations on transactionsRoot and receiptsRoot during syncing #7581

Closed
jframe opened this issue Sep 6, 2024 · 0 comments

Comments

@jframe
Copy link
Contributor

jframe commented Sep 6, 2024

Description

The idea is to avoid calculating the transactionsRoot and receiptsRoot twice during syncing. The transactionsRoot along with the ommersHash, withdrawalsRoot and requestsRoot is calculated in the GetBodiesFromPeerTask to verify the blocks that have been downloaded and again in MainnetBlockBodyValidator when the block is imported. Similar story for receipts with it being calculated once in the download to verify and again in the MainnetBlockBodyValidator.

A previous PR was made to improve this #5679 but the suggested approach is to use a cache instead.

Acceptance Criteria

  • Removes duplicate calculation of roots
  • Improves syncing time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant