yParity is valid up to 2**256 as well

Signed-off-by: Daniel Lehrner <[email protected]>
hyperledger · Sep 20, 2024 · 31b30f6 · 31b30f6
1 parent 0ef4227
commit 31b30f6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/crypto/algorithms/src/main/java/org/hyperledger/besu/crypto/CodeDelegationSignature.java b/crypto/algorithms/src/main/java/org/hyperledger/besu/crypto/CodeDelegationSignature.java
@@ -56,7 +56,7 @@ public static CodeDelegationSignature create(
           "Invalid 's' value, should be < 2^256 but got " + s.toString(16));
     }
 
-    if (yParity.compareTo(TWO_POW_256) > 0) {
+    if (yParity.compareTo(TWO_POW_256) >= 0) {
       throw new IllegalArgumentException(
           "Invalid 'yParity' value, should be < 2^256 but got " + yParity.toString(16));
     }

diff --git a/crypto/algorithms/src/test/java/org/hyperledger/besu/crypto/CodeDelegationSignatureTest.java b/crypto/algorithms/src/test/java/org/hyperledger/besu/crypto/CodeDelegationSignatureTest.java
@@ -78,6 +78,17 @@ void testSValueExceedsTwoPow256() {
         .withMessageContainingAll("Invalid 's' value, should be < 2^256");
   }
 
+  @Test
+  void testYParityExceedsTwoPow256() {
+    BigInteger r = BigInteger.ONE;
+    BigInteger s = BigInteger.TWO;
+    BigInteger yParity = TWO_POW_256;
+
+    assertThatExceptionOfType(IllegalArgumentException.class)
+        .isThrownBy(() -> CodeDelegationSignature.create(r, s, yParity))
+        .withMessageContainingAll("Invalid 'yParity' value, should be < 2^256");
+  }
+
   @Test
   void testValidYParityZero() {
     BigInteger r = BigInteger.ONE;