Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate dids from indy seed secret bytes #1224

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JamesKEbert
Copy link
Contributor

Fixes the Askar implementation of the did_wallet trait function create_and_store_my_did() to match other framework implementations, such as ACA-Py, by deterministically generating a DID from a 'seed' (which in Indy is just the secret key). So this function changes the generation to use Askar's from_secret_bytes instead of from_seed.
See here for some discussion on the topic.

This required adjusting the underlying insert_key() method to only insert a LocalKey and leave the generation up to the call function (which seems like a better idea anyways IMO).

@JamesKEbert JamesKEbert marked this pull request as draft June 11, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant