Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signature and key abstraction for anoncreds #17

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

mikelodder7
Copy link
Contributor

This adds traits that allow for abstracting the keys, signatures, and proofs to allow for more flexibility than hardcoded structs.

Signed-off-by: Michael Lodder <[email protected]>
Signed-off-by: Michael Lodder <[email protected]>
@mikelodder7 mikelodder7 requested a review from swcurran February 28, 2024 00:08
@swcurran
Copy link
Member

swcurran commented Mar 1, 2024

Ran cargo test and got a build error. It’s the same one that failed in the CI tests above. Back to you @mikelodder7

swcur@docket:~/repos/anoncreds-v2-rs (mikelodder7/main)$ cargo test
    Updating crates.io index
  Downloaded vsss-rs v4.0.0-rc2
  Downloaded blsful v2.5.4
  Downloaded 2 crates (702.3 KB) in 1.03s
   Compiling vsss-rs v4.0.0-rc2
   Compiling blsful v2.5.4
   Compiling credx v0.1.0 (/d2/repos/anoncreds-v2-rs)
error[E0599]: no function or associated item named `init` found for struct `pok_signature::PokSignature` in the current scope
  --> src/knox/ps/verifier.rs:64:29
   |
64 |     let res = PokSignature::init(signature, &pk, &proof_messages, &mut rng);
   |                             ^^^^ function or associated item not found in `PokSignature`
   |
  ::: src/knox/ps/pok_signature.rs:12:1
   |
12 | pub struct PokSignature {
   | ----------------------- function or associated item `init` not found for this struct

For more information about this error, try `rustc --explain E0599`.
error: could not compile `credx` (lib test) due to previous error
warning: build failed, waiting for other jobs to finish...

Signed-off-by: Michael Lodder <[email protected]>
Signed-off-by: Michael Lodder <[email protected]>
@swcurran swcurran merged commit 954ed67 into hyperledger:main Mar 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants