Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENS contract for Holesky added #2111

Merged
merged 2 commits into from
Nov 5, 2024
+7 −0
Merged

ENS contract for Holesky added #2111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79a26e8
ens contract for Holesky added
NickSneo Nov 5, 2024
36c96a7
added changelog entry
NickSneo Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline

* bump snapshot version to 4.12.3 [#2101](https://github.com/hyperledger/web3j/pull/2101)
* Add HSM kms implementation [#2105](https://github.com/hyperledger/web3j/pull/2105)
* Added support for Holesky [#2111](https://github.com/hyperledger/web3j/pull/2111)

### BREAKING CHANGES

Expand Down
3 changes: 3 additions & 0 deletions core/src/main/java/org/web3j/ens/Contracts.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ public class Contracts {
public static final String RINKEBY = "0x00000000000C2E074eC69A0dFb2997BA6C7d2e1e";
public static final String GOERLI = "0x00000000000C2E074eC69A0dFb2997BA6C7d2e1e";
public static final String SEPOLIA = "0x00000000000C2E074eC69A0dFb2997BA6C7d2e1e";
public static final String HOLESKY = "0x00000000000C2E074eC69A0dFb2997BA6C7d2e1e";
public static final String LINEA = "0x50130b669B28C339991d8676FA73CF122a121267";
public static final String LINEA_SEPOLIA = "0x5B2636F0f2137B4aE722C01dd5122D7d3e9541f7";

Expand All @@ -37,6 +38,8 @@ public static String resolveRegistryContract(String chainId) {
return GOERLI;
} else if (chainIdLong.equals(ChainIdLong.SEPOLIA)) {
return SEPOLIA;
} else if (chainIdLong.equals(ChainIdLong.HOLESKY)) {
return HOLESKY;
} else if (chainIdLong.equals(ChainIdLong.LINEA)) {
return LINEA;
} else if (chainIdLong.equals(ChainIdLong.LINEA_SEPOLIA)) {
Expand Down
1 change: 1 addition & 0 deletions core/src/main/java/org/web3j/tx/ChainIdLong.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ public class ChainIdLong {
public static final long RINKEBY = 4;
public static final long GOERLI = 5;
public static final long SEPOLIA = 11155111;
public static final long HOLESKY = 17000;
public static final long ROOTSTOCK_MAINNET = 30;
public static final long ROOTSTOCK_TESTNET = 31;
public static final long KOVAN = 42;
Expand Down
2 changes: 2 additions & 0 deletions core/src/test/java/org/web3j/ens/ContractsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.web3j.ens.Contracts.HOLESKY;
import static org.web3j.ens.Contracts.LINEA;
import static org.web3j.ens.Contracts.LINEA_SEPOLIA;
import static org.web3j.ens.Contracts.MAINNET;
Expand All @@ -35,6 +36,7 @@ public void testResolveRegistryContract() {
assertEquals(resolveRegistryContract(ChainIdLong.ROPSTEN + ""), (ROPSTEN));
assertEquals(resolveRegistryContract(ChainIdLong.RINKEBY + ""), (RINKEBY));
assertEquals(resolveRegistryContract(ChainIdLong.SEPOLIA + ""), (SEPOLIA));
assertEquals(resolveRegistryContract(ChainIdLong.HOLESKY + ""), (HOLESKY));
assertEquals(resolveRegistryContract(ChainIdLong.LINEA + ""), (LINEA));
assertEquals(resolveRegistryContract(ChainIdLong.LINEA_SEPOLIA + ""), (LINEA_SEPOLIA));
}
Expand Down
Loading