Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web3j extends AutoClosable Interface #2102

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Web3j extends AutoClosable Interface #2102

merged 1 commit into from
Sep 25, 2024

Conversation

steffenboe
Copy link
Contributor

What does this PR do?

Makes Web3j autoclosable to use it in try-with-resources blocks, as wished for in #1983 .

Where should the reviewer start?

At the Web3j Interface, extending the AutoClosable Interface.

Why is it needed?

So users do not forget to close the Web3j instance.

Checklist

  • I've read the contribution guidelines.
  • I've added tests (if applicable).
  • I've added a changelog entry if necessary.

NickSneo
NickSneo approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@NickSneo NickSneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickSneo NickSneo merged commit 8fa31dd into hyperledger-web3j:main Sep 25, 2024
6 checks passed
@steffenboe steffenboe mentioned this pull request Sep 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickSneo NickSneo NickSneo approved these changes

@conor10 conor10 Awaiting requested review from conor10 conor10 is a code owner

@gtebrean gtebrean Awaiting requested review from gtebrean gtebrean is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steffenboe @NickSneo