Make getABI_* calls in wrapper should be static #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tonykwok1992 <[email protected]>
tonykwok1992
requested review from
conor10,
gtebrean and
NickSneo
as code owners
tonykwok1992
changed the title
NickSneo
requested changes
Jul 16, 2024
| contract AbiFuncs { | ||
|
|
||
|
|
||
| function hi(uint256 x) public { |
There was a problem hiding this comment.
This seems like an empty solidity file, can't we reuse any pre-existing .sol file for the test?
There was a problem hiding this comment.
I also want to test java file output matches, if I use any existing file, I will have to modify those java files to add getABI* calls, but that will actually invalidate the test case with abiFunc=false
| @@ -0,0 +1 @@ | |||
| [{"inputs":[{"internalType":"uint256","name":"x","type":"uint256"}],"name":"hi","outputs":[],"stateMutability":"nonpayable","type":"function"}] | |||
There was a problem hiding this comment.
Same lets use any existing solidity and compile .abi and .bin files
Julius278
pushed a commit
to Julius278/web3j
that referenced
this pull request
Jul 30, 2024
Signed-off-by: tonykwok1992 <[email protected]> Signed-off-by: Julius Lauterbach <[email protected]>
Julius278
pushed a commit
to Julius278/web3j
that referenced
this pull request
Jul 30, 2024
Signed-off-by: tonykwok1992 <[email protected]> Signed-off-by: Julius Lauterbach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
getABI_* call in wrapper should be static method. we do not need an instance of wrapper to encode function
Where should the reviewer start?
All files
Why is it needed?
we do not need an instance of wrapper to encode function
Checklist