Add Constructor Support for Solang Solidity Contracts on Soroban #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onstructor Signed-off-by: Tarek <[email protected]>
tareknaser
requested review from
seanyoung,
xermicus and
LucasSte
as code owners
tareknaser
force-pushed
the
soroban_constructor22
branch
2 times, most recently
from
239ae3f to
ecac9fe
Compare
Signed-off-by: Tarek <[email protected]>
tareknaser
force-pushed
the
soroban_constructor22
branch
from
ecac9fe to
b66e4af
Compare
Signed-off-by: Tarek <[email protected]>
tareknaser
force-pushed
the
soroban_constructor22
branch
from
b66e4af to
ba848bb
Compare
| @@ -15,7 +15,7 @@ jobs: | |||
| uses: actions/checkout@v4 | |||
| with: | |||
| submodules: recursive | |||
| - uses: dtolnay/rust-toolchain@1.75.0 | |||
| - uses: dtolnay/rust-toolchain@1.81.0 | |||
There was a problem hiding this comment.
Why is that change related to the PR?
There was a problem hiding this comment.
soroban-sdk 22.0.0-rc.3.2 requires rustc 1.79.0 or newer, and soroban-cli (which we use in the CI) now requires rustc 1.81.0 or newer.
salaheldinsoliman
approved these changes
Nov 23, 2024
salaheldinsoliman
merged commit de4fc34
into
hyperledger-solang:main
17 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step towards implementing #1672. It adds constructor support for Solidity contracts in Solang. The next step, not covered in this PR, is handling cases where the user defines a
__constructorfunction with custom logic. More details can be found in the issue discussion.Changes Made
initfunction (used to callstorage_initializers) to__constructorso that it is recognized and invoked by the Soroban host environment.