Add print functionality to Soroban contracts #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salaheldinsoliman
force-pushed
the
feat/soroban_print
branch
from
fd5cdca to
1b8aba0
Compare
salaheldinsoliman
force-pushed
the
feat/soroban_print
branch
from
535e648 to
2bbba8e
Compare
salaheldinsoliman
force-pushed
the
feat/soroban_print
branch
from
c656939 to
38dde1c
Compare
salaheldinsoliman
requested review from
seanyoung,
xermicus and
LucasSte
as code owners
seanyoung
reviewed
Aug 19, 2024
src/codegen/expression.rs
Outdated
| loc, | ||
| ty, | ||
| size: _, | ||
| initializer, |
There was a problem hiding this comment.
This should really be: initializer: Some(initializer),
src/lib.rs
Outdated
| @@ -95,7 +95,7 @@ impl Target { | |||
|
|
|||
| /// Size of a pointer in bits | |||
| pub fn ptr_size(&self) -> u16 { | |||
| if *self == Target::Solana { | |||
| if *self == Target::Solana || *self == Target::Soroban { | |||
There was a problem hiding this comment.
I thought Soroban uses wasm which has 32 bit address space, unless it's wasm64
There was a problem hiding this comment.
Thanks, that was a typo
|
@seanyoung Can I get a second look on this one? |
seanyoung
approved these changes
Sep 12, 2024
.github/workflows/test.yml
Outdated
Comment on lines
494
to
497
| run: | | ||
| export DBUS_SESSION_BUS_ADDRESS=/dev/null | ||
| export NO_AT_BRIDGE=1 | ||
| xvfb-run --auto-servernum --server-args="-screen 0 1920x1080x24" npm test -- --disable-gpu |
There was a problem hiding this comment.
These changes don't fix the issue of the vscode test not working. For some reason the tap package is not installed, it's not xvfb-run
There was a problem hiding this comment.
Let me just remove that and address it in a further PR then
|
LGTM, thank you! |
Signed-off-by: salaheldinsoliman <[email protected]>
salaheldinsoliman
force-pushed
the
feat/soroban_print
branch
from
d37c0af to
f2695f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds static string print functionality to Soroban contracts. This serves the following:
print()statementsHowever, the following findings might be interesting:
In both Solana and Polkadot, the VM execution capacity can grasp a call to
vector_newin thestdlib: https://github.com/hyperledger/solang/blob/06798cdeac6fd62ee98f5ae7da38f3af4933dc0f/stdlib/stdlib.c#L167However, Soroban doesn't. That's why Soroban would need Solang to implement a more efficient way of printing dynamic strings.
@leighmcculloch