Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Each call to new_scope() should be matched with leave_scope() #1562

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

seanyoung
Copy link
Contributor

@seanyoung seanyoung commented Oct 9, 2023

The try catch blocks had an additional new_scope() which is incorrect. I think the extra scope is harmless but let's clean it up.

Rename new_scope() to enter_scope() as this matches leave_scope() better.

The try catch blocks had an additional new_scope() which is incorrect.
I think the extra scope is harmless but let's clean it up.

Signed-off-by: Sean Young <[email protected]>
@seanyoung seanyoung marked this pull request as ready for review October 9, 2023 12:57
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #1562 (4d13c4b) into main (a9e20d3) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1562   +/-   ##
=======================================
  Coverage   87.35%   87.36%           
=======================================
  Files         133      133           
  Lines       64126    64125    -1     
=======================================
+ Hits        56019    56021    +2     
+ Misses       8107     8104    -3     
Files Coverage Δ
src/codegen/statements/mod.rs 96.77% <100.00%> (ø)
src/codegen/yul/statements.rs 98.13% <100.00%> (ø)
src/sema/statements.rs 93.80% <100.00%> (-0.01%) ⬇️
src/sema/symtable.rs 92.70% <100.00%> (ø)
src/sema/yul/block.rs 100.00% <100.00%> (ø)
src/sema/yul/for_loop.rs 95.14% <100.00%> (ø)
src/sema/yul/functions.rs 84.40% <100.00%> (ø)
src/sema/yul/mod.rs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@seanyoung seanyoung merged commit 6b04c23 into hyperledger-solang:main Oct 18, 2023
19 checks passed
@seanyoung seanyoung deleted the scopes branch October 18, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants