Fix proof generation handling of empty sibilings #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Chengxuan
reviewed
Sep 20, 2024
| @@ -104,14 +104,29 @@ func (mt *sparseMerkleTree) GetNode(key core.NodeIndex) (core.Node, error) { | |||
| // GenerateProof generates the proof of existence (or non-existence) of a leaf node | |||
| // for a Merkle Tree given the root. It uses the node's index to represent the node. | |||
| // If the rootKey is nil, the current merkletree root is used | |||
| func (mt *sparseMerkleTree) GenerateProof(k *big.Int, rootKey core.NodeIndex) (core.Proof, *big.Int, error) { | |||
| func (mt *sparseMerkleTree) GenerateProofs(keys []*big.Int, rootKey core.NodeIndex) ([]core.Proof, []*big.Int, error) { | |||
There was a problem hiding this comment.
I read this code several times trying to understand how this could relate to the problem described. then realized it's a just a refactor for code convenience. the description of the methods is not updated.
There was a problem hiding this comment.
yeah sorry this was a necessary improvement so that multiple proofs can be generated against the same root inside the sync'ed routine
Chengxuan
approved these changes
Sep 20, 2024
Chengxuan
reviewed
Sep 20, 2024
Co-authored-by: Chengxuan Xing <[email protected]> Signed-off-by: jimthematrix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Proof object usually contains empty nodes, for efficiency we don't lug the empty node around but instead use a byte array of length 32, so that there are 256 bits one for each level, to indicate which levels are empty/non-empty.
This fixes some bugs in the handling of the array with both marking the bits and reading the bits