-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circuit compile and proving key gen enhancements #36
Conversation
Signed-off-by: Jim Zhang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 58.58% 63.75% +5.17%
==========================================
Files 18 12 -6
Lines 606 538 -68
==========================================
- Hits 355 343 -12
+ Misses 209 152 -57
- Partials 42 43 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
@@ -11,7 +11,7 @@ GOGC=30 | |||
|
|||
all: test go-mod-tidy | |||
test: deps lint | |||
$(VGO) test ./internal/... ./pkg/... -cover -coverprofile=coverage.txt -covermode=atomic -timeout=30s ${TEST_ARGS} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the pkg folder now only contains interfaces and simple wrapper code, it does seem if we have tests in this folder, they'll mostly be boiler plate code.
As long as we can ensure other contributors know this convention, we should be fine.
Signed-off-by: Chengxuan Xing <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed a commit with some changes for first time users: 1f80f1f
-c anon -c anon_nullifier
CIRCUITS_ROOT
rather than always assuming the circuit WASM to be in the local lib folder