Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several bugs in the service data routines for verification #482

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

cmickeyb
Copy link
Contributor

Small changes to fix several problems with the way last_verified_time is handled in the service data store. Improves variable naming and ensures that the value of last_verified_time is pushed through.

@cmickeyb cmickeyb added the bug Something isn't working label Mar 26, 2024
@cmickeyb cmickeyb requested review from g2flyer and bvavala March 26, 2024 14:32
Copy link
Contributor

@g2flyer g2flyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me afaict -- i'm not very familiar with this code .... -- and test still works nicely

@cmickeyb
Copy link
Contributor Author

Code looks good to me afaict -- i'm not very familiar with this code .... -- and test still works nicely

which really means that we need to do a better job of testing verification. pdo-shell does not make checking a specific numeric value easy. may need to add some support just to make writing tests like this easier.

Copy link
Member

@bvavala bvavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@bvavala bvavala merged commit b3bbd5f into hyperledger-labs:main Mar 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants