Resistant event subs #116
Merged
Resistant event subs #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggwpez
force-pushed
the
40-resistant-event-subs
branch
2 times, most recently
from
7b22232
to
f963424
Compare
ggwpez
commented
Aug 19, 2021
ggwpez
commented
Aug 19, 2021
Closed
ggwpez
force-pushed
the
40-resistant-event-subs
branch
from
f963424
to
3274d4f
Compare
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
force-pushed
the
40-resistant-event-subs
branch
3 times, most recently
from
931187e
to
52211ad
Compare
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
force-pushed
the
40-resistant-event-subs
branch
from
83ffb1a
to
b562049
Compare
matthiasgeihs
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
ResistantEventSubtype.Also introduced a convenience function
Subscribe(ctx context.Context, cr ethereum.ChainReader, contract *bind.BoundContract, eFact EventFactory, startBlockOffset, confirmations uint64) (*ResistantEventSub, error)which makes it easier to create a resistant sub.I am not happy with the arguments of
Subscribeyet, since it are so many.Closes #40
Draft until #105 is closed