Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: updating DIDComm presentation protocols #383

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat!: updating DIDComm presentation protocols #383

wants to merge 1 commit into from

Conversation

curtis-h
Copy link
Contributor

@curtis-h curtis-h commented Feb 13, 2025 •
edited
Loading

Description:

#359

Updating didcomm protocols for presentation to be closer to specification.

BREAKING CHANGES:

  • Presentation.makePresentationFromRequest removed
  • ProposePresentation.makeProposalFromRequest removed
  • RequestPresentation.makeRequestFromProposal removed
  • ProofTypes interface removed

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@curtis-h curtis-h requested a review from a team February 13, 2025 10:39
@curtis-h curtis-h changed the title feat: updating DIDComm presentation protocols feat!: updating DIDComm presentation protocols Feb 13, 2025
@curtis-h curtis-h force-pushed the feature/359-protocols-presentation branch from 2fd0b25 to f072c12 Compare February 13, 2025 10:47
@curtis-h curtis-h force-pushed the feature/359-protocols-presentation branch from f072c12 to 404741b Compare February 13, 2025 10:50
FabioPinheiro
FabioPinheiro approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@FabioPinheiro FabioPinheiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me looks good

@coveralls
Copy link

coveralls commented Feb 13, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13306019043

Details

  • 12 of 19 (63.16%) changed or added relevant lines in 3 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 73.813%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/edge-agent/protocols/proofPresentation/Presentation.ts 3 5 60.0%
src/edge-agent/protocols/proofPresentation/ProposePresentation.ts 4 6 66.67%
src/edge-agent/protocols/proofPresentation/RequestPresentation.ts 5 8 62.5%
Files with Coverage Reduction New Missed Lines %
src/edge-agent/protocols/proofPresentation/ProposePresentation.ts 3 67.74%
src/edge-agent/protocols/proofPresentation/Presentation.ts 3 67.74%
Totals Coverage Status
Change from base Build 13290058689: -0.02%
Covered Lines: 3339
Relevant Lines: 4302
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabioPinheiro FabioPinheiro FabioPinheiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curtis-h @coveralls @FabioPinheiro