Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix documentation main package and fix castor verifySignature … #378

Conversation

elribonazo
Copy link
Contributor

@elribonazo elribonazo commented Feb 6, 2025

Description:

Small docs improvement. We have changed the typedoc namespace to be @hyperledger/identus-edge-agent-sdk, whatever is in the main package json, we will no longer have this issue (wrong namespace pointing to @Atala)

Also made a small fix into Castor verifySignature method that was showing code prior to the cryptographic abstraction epic and is now showing a valid code example.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@elribonazo elribonazo linked an issue Feb 6, 2025 that may be closed by this pull request
@elribonazo elribonazo force-pushed the 377-fix-castor-documentation-pointing-to-apollosignstringmessage branch from 711183f to 52cfc66 Compare February 6, 2025 10:53
@elribonazo elribonazo marked this pull request as ready for review February 6, 2025 10:54
@elribonazo elribonazo requested a review from a team as a code owner February 6, 2025 10:54
Copy link

github-actions bot commented Feb 6, 2025

Lines Statements Branches Functions
Coverage: 77%
78.15% (3742/4788) 68.17% (1729/2536) 82.13% (892/1086)

@coveralls
Copy link

Coverage Status

coverage: 74.511%. remained the same
when pulling 52cfc66 on 377-fix-castor-documentation-pointing-to-apollosignstringmessage
into ebe1c80 on main.

@elribonazo elribonazo merged commit 4fa5b1d into main Feb 6, 2025
7 checks passed
@elribonazo elribonazo deleted the 377-fix-castor-documentation-pointing-to-apollosignstringmessage branch February 6, 2025 11:09
elribonazo added a commit that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix Castor documentation pointing to Apollo.signStringMessage
3 participants