Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implementing the Hyperledger Identus SDJWT workshop #323

Merged
merged 7 commits into from
Nov 8, 2024

Conversation

elribonazo
Copy link
Contributor

@elribonazo elribonazo commented Nov 5, 2024

Description:

This PR not just brings the Workshop but the ability to build specific workshops easily in a single screen.

We can do so by defining each step with code examples and API calls and configure the interactive demo to do what we design it to do on each step.

  • We must Add examples on how to start the agent and the mediator from windows, linux and mac.
  • We must improve the examples in a clear way to it explicitly tells the users the files they need to create, etc
  • We add a final step with the complete code.
  • Improve UX of the Accept OOB buttons, show loading until the offer or presentation request is parsed and message emitted.
  • Improve the UX for the Accept Credential Offer message, not showing loading button until the issued credential arrives.
  • Improve the User experience, make all the buttons have the same size.
  • Add more texts to clarify the missing steps that are empty. step === text + description
  • Add github image from hyperledger into the header
  • Configuring the mediator using its endpoint and show how to apply this in the code.
  • Add pharmacy, patient and doctor issuance example
  • Improve the user experience by grouping the API calls in blocks
  • Improve code output formatting

@elribonazo elribonazo linked an issue Nov 5, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Nov 5, 2024

Lines Statements Branches Functions
Coverage: 75%
76.08% (3633/4775) 66.49% (1665/2504) 80.29% (864/1076)

@coveralls
Copy link

coveralls commented Nov 5, 2024

Pull Request Test Coverage Report for Build 11742283733

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.553%

Totals Coverage Status
Change from base Build 11700452182: 0.0%
Covered Lines: 3524
Relevant Lines: 4648

💛 - Coveralls

@elribonazo elribonazo force-pushed the feature/hyperledger-workshop branch from 2226951 to b24cdf3 Compare November 5, 2024 20:54
@elribonazo elribonazo force-pushed the feature/hyperledger-workshop branch 2 times, most recently from 4d73aca to e586948 Compare November 6, 2024 13:21
@elribonazo elribonazo marked this pull request as ready for review November 6, 2024 13:22
@elribonazo elribonazo requested a review from a team as a code owner November 6, 2024 13:22
@elribonazo elribonazo force-pushed the feature/hyperledger-workshop branch from e586948 to 0a8aba1 Compare November 6, 2024 13:29
demos/next-sdjwt-workshop/README.md Outdated Show resolved Hide resolved
demos/next-sdjwt-workshop/README.md Outdated Show resolved Hide resolved
demos/next-sdjwt-workshop/src/pages/index.tsx Outdated Show resolved Hide resolved
demos/next-sdjwt-workshop/src/pages/index.tsx Outdated Show resolved Hide resolved
@elribonazo elribonazo force-pushed the feature/hyperledger-workshop branch from 8115321 to a3fde95 Compare November 6, 2024 14:04
@FabioPinheiro
Copy link
Contributor

Why are wee adding images like demos/next-sdjwt-workshop/public/vercel.svg ?

@FabioPinheiro FabioPinheiro force-pushed the feature/hyperledger-workshop branch from ab62a76 to 65f70ae Compare November 6, 2024 18:42
@elribonazo elribonazo force-pushed the feature/hyperledger-workshop branch 5 times, most recently from 2c7fb20 to eddfe14 Compare November 7, 2024 15:27
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
@elribonazo elribonazo force-pushed the feature/hyperledger-workshop branch from 20fae04 to d973000 Compare November 7, 2024 15:31
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
@elribonazo elribonazo force-pushed the feature/hyperledger-workshop branch from 523e0f9 to 8724abc Compare November 7, 2024 15:42
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
@elribonazo elribonazo force-pushed the feature/hyperledger-workshop branch from daca0ac to ebccd46 Compare November 8, 2024 12:39
@elribonazo elribonazo merged commit 8b0a7be into main Nov 8, 2024
6 checks passed
@elribonazo elribonazo deleted the feature/hyperledger-workshop branch November 8, 2024 12:55
elribonazo added a commit that referenced this pull request Nov 12, 2024
jeyem pushed a commit to socious-io/identus-edge-agent-sdk-ts that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hyperledger workshop preparation
5 participants