Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: migrate to hyperledger-identus org and Docker Hub #1520

Merged
merged 20 commits into from
Feb 13, 2025
Merged

build: migrate to hyperledger-identus org and Docker Hub #1520

merged 20 commits into from
Feb 13, 2025

Conversation

yshyn-iohk
Copy link
Contributor

@yshyn-iohk yshyn-iohk commented Feb 12, 2025 •
edited
Loading

Description:

  1. fixed links after migration to the new org: hyperledger-identus
  2. modified revision build to publish the snapshot to the Docker Hub

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@yshyn-iohk
chore: fix the url links
ed74992 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
chore: fix CODEOWNERS
e5b4166 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
chore: delete outdated files
fda0f11 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
ci: configure Docker Hub for publishing the revision
0754c43 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
ci: rollback --load flag
99b6d46 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 12, 2025 •
edited
Loading

Integration Test Results

 23 files  ±0   23 suites  ±0   3s ⏱️ ±0s
 56 tests ±0   56 ✅ ±0  0 💤 ±0  0 ❌ ±0 
103 runs  ±0  103 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a7528d3. ± Comparison against base commit 8147901.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 12, 2025 •
edited
Loading

Unit Test Results

105 files  ±0  105 suites  ±0   16m 44s ⏱️ - 6m 24s
889 tests ±0  881 ✅ +12  8 💤 ±0  0 ❌  - 12 
896 runs  ±0  888 ✅ +12  8 💤 ±0  0 ❌  - 12 

Results for commit a7528d3. ± Comparison against base commit 8147901.

♻️ This comment has been updated with latest results.

@yshyn-iohk
ci: remove docker image tags
a75e288 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
build: configure NPMJS and Maven repositories
0fd02a0 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
build: add gradle plugin for publishing to Maven
6285ee1 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
chore: wip debug maven publishing
1d98486 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
build: reconfigure gradle project for http client
4327bd0 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
build: fix yarn publishing to NPMJS
b1876e6 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
build: another try
4edf604 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
build: add --debug
55de82b 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
build: another try
474964c 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
rollback: migration to npmjs and maven central
0639b9d 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
chore: cleanup and make npm package public
f29d911 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
build: migrate release.yml flow to the Docker Hub
bde2768 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
style: megalinter fixes
7c1e284 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
build: change the tag format to a short form vX.X.X
80b1bd7 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@github-actions @hyperledger-bot @yshyn-iohk
style: apply linters automatic fixes (#1527)
a7528d3 
Signed-off-by: Hyperledger Bot <[email protected]>
Co-authored-by: Hyperledger Bot <[email protected]>
Co-authored-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk yshyn-iohk enabled auto-merge (squash) February 13, 2025 12:46
FabioPinheiro
FabioPinheiro requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@FabioPinheiro FabioPinheiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is just one small change, but everything else seems good

.github/workflows/build.yml
run: |
sbt "set version := \"${{ env.BUILD_VERSION }}\"" "docker:stage"
docker buildx build --platform=linux/arm64,linux/amd64 --push -t ghcr.io/hyperledger/identus-cloud-agent:${{ env.BUILD_VERSION}} ./cloud-agent/service/server/target/docker/stage
docker buildx build --platform=linux/arm64,linux/amd64 --push -t ${{ vars.DOCKERHUB_ORG }}/identus-cloud-agent:${{ env.BUILD_VERSION }} ./cloud-agent/service/server/target/docker/stage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you missing the docker.io

Suggested change
docker buildx build --platform=linux/arm64,linux/amd64 --push -t ${{ vars.DOCKERHUB_ORG }}/identus-cloud-agent:${{ env.BUILD_VERSION }} ./cloud-agent/service/server/target/docker/stage
docker buildx build --platform=linux/arm64,linux/amd64 --push -t docker.io/${{ vars.DOCKERHUB_ORG }}/identus-cloud-agent:${{ env.BUILD_VERSION }} ./cloud-agent/service/server/target/docker/stage

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FabioPinheiro, afaik, docker.io is a default registry for the docker command
I tested this in the build.yml workflow here

@yshyn-iohk yshyn-iohk merged commit 9288470 into main Feb 13, 2025
13 checks passed
@yshyn-iohk yshyn-iohk deleted the ci/1514 branch February 13, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabioPinheiro FabioPinheiro FabioPinheiro approved these changes

@amagyar-iohk amagyar-iohk amagyar-iohk approved these changes

@mineme0110 mineme0110 Awaiting requested review from mineme0110

Assignees
No one assigned
Labels
ci cloud-agent docs shared
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yshyn-iohk @FabioPinheiro @amagyar-iohk