Skip to content
This repository was archived by the owner on Mar 11, 2024. It is now read-only.

Upgrade aead/aes/aes-gcm/block-modes/chacha20poly1305 crates #124

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

tarcieri
Copy link
Contributor

@tarcieri tarcieri commented Jun 8, 2020

Updates the following crates:

  • aead => v0.3
  • aes => v0.4
  • aes-gcm => v0.6.0
  • block-modes => v0.4
  • chacha20poly1305 => v0.5.0

Some aead v0.3 update notes:

  • NewAead now borrows the key, preventing unnecessary copies
  • Aead and AeadInPlace were split into two different traits. This lets you get rid of the stubbed out *_in_place* methods on your Aead impls (introduced in Upgrade aead/aes-gcm/chacha20poly1305 crates #91)

More release notes here: RustCrypto/traits#174

The other crate updates use the new traits and also upgrade generic-array to v0.14, which has MSRV 1.41+.

Signed-off-by: Tony Arcieri [email protected]

@tarcieri
Copy link
Contributor Author

tarcieri commented Jun 8, 2020

The asm build failure looks unrelated:

error: the legacy LLVM-style asm! syntax is no longer supported
   --> /home/vsts/.cargo/registry/src/github.com-1ecc6299db9ec823/subtle-2.2.2/src/lib.rs:150:14
    |
150 |     unsafe { asm!("" : "=r"(input) : "0"(input) ) }
    |              ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |              |
    |              help: replace with: `llvm_asm!`
    |
    = note: consider migrating to the new asm! syntax specified in RFC 2873
    = note: alternatively, switch to llvm_asm! to keep your code working as it is

@mikelodder7
Copy link
Contributor

I have PR open that should fix the ASM issue. Thanks for this PR. As long as the other checks pass we should be good.

@mikelodder7 mikelodder7 force-pushed the aead/v0.3 branch 2 times, most recently from e84bc5f to bd69030 Compare June 23, 2020 13:23
Updates the following crates:

- `aead` => v0.3
- `aes` => v0.4
- `aes-gcm` => v0.6.0
- `block-modes` => v0.4
- `chacha20poly1305` => v0.5.0

Some `aead` v0.3 update notes::

- `NewAead` now borrows the key, preventing unnecessary copies
- `Aead` and `AeadInPlace` were split into two different traits.
  This lets you get rid of the stubbed out `*_in_place` methods
  on your `Aead` impls (introduced in hyperledger-archives#91)

More release notes here: RustCrypto/traits#174

The other crate updates use the new traits and also upgrade
`generic-array` to v0.14, which has MSRV 1.41+.

Signed-off-by: Tony Arcieri <[email protected]>
@mikelodder7 mikelodder7 merged commit 072b0f3 into hyperledger-archives:master Jun 23, 2020
@tarcieri tarcieri deleted the aead/v0.3 branch June 23, 2020 13:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants