This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Fix GitHub actions pythonpath and disable broken adm lmdb tests #2462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required in order to find the sawtooth_validator python package while running the tests. Signed-off-by: Shawn T. Amundson <[email protected]>
These tests look for an lmdb database and error that it is not found. It is not clear if additional setup is expected for these tests or if it indicates a behavioral change in lmdb auto-creation. In either case, perhaps these tests should be restored in the future in a non-broken form. Signed-off-by: Shawn T. Amundson <[email protected]>
vaporos
requested review from
agunde406,
cianx,
dcmiddle,
jsmitchell,
peterschwarz,
rberg2 and
rbuysse
as code owners
This step is necessary when building because it generates the python protobuf bindings from the sawtooth proto files. This requires installing python grpcio-tools (for example, with pip). Signed-off-by: Shawn T. Amundson <[email protected]>
This is necessary given changes in justfile which run protogen. Signed-off-by: Shawn T. Amundson <[email protected]>
jsmitchell
approved these changes
Oct 25, 2023
agunde406
approved these changes
Oct 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expectation is that this will pass the build github action.