Skip to content
This repository has been archived by the owner on Jan 22, 2020. It is now read-only.

Edx issue103 #105

Open
wants to merge 11 commits into
base: import-edx-content
Choose a base branch
from
Open

Edx issue103 #105

wants to merge 11 commits into from

Conversation

nathalie-ckc
Copy link

Building on top of @atc-vince 's PR#104.

Each item from Github issue #103 is implemented as a separate commit. In case any of those items are not desired to be implemented, just the desired items can be cherry picked.

atc-vince and others added 10 commits October 7, 2018 18:28
@atc-vince @nathalie-ckc
Chapter 8: What's Next Markdown
69a3585 
Signed-off-by: atc-vince <[email protected]>
@atc-vince @nathalie-ckc
Chapters 6 & 7 Markdown w/ Images
bbf1fbd 
Signed-off-by: atc-vince <[email protected]>
@nathalie-ckc
Issue hyperledger-archives#103 item 1: Fix typo
81c8761 
"does not ... maintain"

Signed-off-by: nathalie-ckc <[email protected]>
@nathalie-ckc
Issue hyperledger-archives#103 item 2: Move diagram to relevant slide
7e62abf 
Item 2a:
The diagram doesn’t describe the flow in the text. The diagram matches
the text on the previous slide (Membership Service Provider (MSP))
better, so I propose to move it there.

Item 2b was a stretch goal, which I didn't have time to implement.

Signed-off-by: nathalie-ckc <[email protected]>
@nathalie-ckc
Issue hyperledger-archives#103 item 3: Update version in command
d668d01 
I got errors following the steps for installing the fabric docker images
and binaries.

Discussion forum post by tianzhong2015 at
https://courses.edx.org/courses/course-v1:LinuxFoundationX+LFS171x+3T2017/discussion/forum/i4x-LinuxFoundationX-LFS171x-course-3T_2017/threads/5b6939f8c305ad0a19000db7
indicates that we should use version 1.2.0 to avoid the errors, and that
worked for me.

I propose to change the command to 'curl -sSL https://goo.gl/6wtTN5 |
bash -s 1.2.0'

Signed-off-by: nathalie-ckc <[email protected]>
@nathalie-ckc
Issue hyperledger-archives#103 item 4: Indicate what we want replaced
650edd1 
In the actual edX course: “the blue portion in the above curl command” There is no blue portion...

Then in markdown, you can't specify color anyway (not even with HTML),
so I specified what is the text to replace.

Signed-off-by: nathalie-ckc <[email protected]>
@nathalie-ckc
Issue hyperledger-archives#103 item 5: Specify 'fabric'
0bf5c18 
I propose to change “perform the following command for each of the
Docker images:” to “perform the following command for each of the Fabric
docker images" because, if you just did Chapter 6, you would have all
the sawtooth images too & we don't mean for them to also tag those as
latest.

Likewise for the paragraph below that one.

Signed-off-by: nathalie-ckc <[email protected]>
@nathalie-ckc
Issue hyperledger-archives#103 item 6: specify what to replace
a980f68 
“$ docker tag hyperledger/fabric-tools:x86_64-1.0.2
hyperledger/fabric-tools:latest” I think there needs to be 2 red
portions (both 'fabric-tools'), but just 1 is red in the edX course.

Then in markdown, you can't specify color anyway (not even with HTML),
so I specified what is the text to replace.

Signed-off-by: nathalie-ckc <[email protected]>
@nathalie-ckc
Issue hyperledger-archives#103 item 7: Delete redundant slide
854aeb6 
'Installing Hyperledger Fabric' is a redundant slide.

First, the slide 'Installing Hyperledger Fabric Docker Images and
Binaries' caused fabric-samples to be cloned already. I updated that
slide accordingly, because the 'bin' is no longer in the current
subdir, but rather in 'fabric-samples/bin'.

Second, you should cd into fabric-samples before you do the $PWD because
you want fabric-samples/bin, but you don’t even need to do that because
byfn.sh takes care of it for you on line 31.

So, I deleted the slide and updated the slide 'Getting Started with Your
First Network' to have you cd into 'fabric-samples/first-network'.

Signed-off-by: nathalie-ckc <[email protected]>
@nathalie-ckc
Issue hyperledger-archives#103 item 8: Add troubleshooting tips
5520e3e 
'node registerAdmin.jsr' fails with syntax error. Some students also
filed Github issue hyperledger-archives#64 about this.

This post has the solution:
https://courses.edx.org/courses/course-v1:LinuxFoundationX+LFS171x+3T2017/discussion/forum/i4x-LinuxFoundationX-LFS171x-course-3T_2017/threads/5b472605c5264809bd00139c

I installed nvm using the instructions on the nvm github page README
at https://github.com/creationix/nvm

Then I did 'nvm install v8.9.0', as recommended by the discussion
post

Then I did 'npm install' again in the tuna-app directory, but got
warnings about high risk vulnerabilities, so I ran the commands
recommended in the warnings:

    npm I npm@latest -g
    npm install
    npm audit fix

did ‘npm install’ again & just low risk vulnerabilities remaining.

Was able to continue with the exercise from here.

I propose to add to add another Troubleshooting section with the
suggestion that you might need v8.9.0 and give the pointer to the nvm
repo to install nvm, 'nvm install v8.9.0' and repeat 'npm install'

Signed-off-by: nathalie-ckc <[email protected]>
@atc-vince
Copy link

atc-vince commented Oct 8, 2018 via email

@nathalie-ckc
Copy link
Author

I just realized that in deleting the redundant slide for item 7, the table of contents didn't get updated. I'll fix that today.

@nathalie-ckc
Issue hyperledger-archives#103 item 7 part 2: Update TOC
74cff74 
Deleting slide for item 7 didn't result in the TOC getting updated (Atom
package is supposed to update TOC on save), so I am deleting the TOC
entry for that slide manually.

Signed-off-by: nathalie-ckc <[email protected]>
@nathalie-ckc
Copy link
Author

OK, just pushed that change for item 7. Feel free to cherry pick whichever items from issue #103 that you think are valid, and leave behind the rest.

tkuhrt
tkuhrt reviewed Oct 16, 2018
View reviewed changes
LFS171x/docs/introduction-to-hyperledger-fabric.md
@@ -415,7 +415,7 @@ If you need further details on these prerequisites, visit Chapter 4, _Technical
Next, we will download the latest released Docker images for Hyperledger Fabric, and tag them with the **latest** tag. Execute the command from within the directory into which you will extract the platform-specific binaries:

```
$ curl -sSL https://goo.gl/6wtTN5 | bash -s 1.1.0
$ curl -sSL https://goo.gl/6wtTN5 | bash -s 1.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest command is this
curl -sSL http://bit.ly/2ysbOFE | bash -s 1.3.0

Have we verified that the code works with 1.3.0?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried that today and it seems to work.

TO DO after the next comment from @tkuhrt is resolved:
Also update the link to go find the new URL to https://hyperledger-fabric.readthedocs.io/en/release-1.3/install.html and the screenshot of docker images to
image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DBAti, you mentioned in today's Training & Education Working Group call that you hit issues with the 1.3 Fabric stuff? I just went to the end of the 1st example with the 1.3.0 instruction above that Tracy gave. I didn't have time to go through entire chapter with 1.3. Please could you let us know the details of what you encountered?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nathalie-ckc @tkuhrt - let event_hub = fabric_client.newEventHub(); this is the function creating the problem with new fabric-client 1.3.0, as I know for now.
It needs to be changed to let event_hub = channel.newChannelEventHub('localhost:7051');

tkuhrt
tkuhrt reviewed Oct 16, 2018
View reviewed changes
LFS171x/docs/introduction-to-hyperledger-fabric.md
@@ -420,7 +420,7 @@ $ curl -sSL https://goo.gl/6wtTN5 | bash -s 1.2.0

__**NOTE:**__ Check [http://hyperledger-fabric.readthedocs.io/en/release-1.1/samples.html#binaries](http://hyperledger-fabric.readthedocs.io/en/release-1.1/samples.html#binaries) for the latest URL (the 'https://goo.gl/6wtTN5' in the above curl command) to pull in binaries.

This command downloads binaries for **cryptogen**, **configtxgen**, **configxlator**, **peer** AND downloads the Hyperledger Fabric Docker images. These assets are placed in a **bin** subdirectory of the current working directory.
This command downloads binaries for **cryptogen**, **configtxgen**, **configxlator**, **peer** AND downloads the Hyperledger Fabric Docker images. These assets are placed in the **fabric-samples/bin** subdirectory of the current working directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation says places them in the bin sub-directory of the current working directory.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started with an empty directory and called the command for the 1.3 version and I am still seeing the same behavior, where these binaries are appearing in fabric-samples/bin. Perhaps the reason is related to this error message that shows up right at the beginning, but doesn't seem to otherwise impact the rest of the example running "bash: line 181: [: too many arguments".

nathalie@nathalie-HP-EliteBook-8460p:~/Hyperledger/LFS171x/Fabric$ curl -sSL http://bit.ly/2ysbOFE | bash -s 1.3.0
bash: line 181: [: too many arguments
...

Once everthing has finished running from that curl command above, an ls shows that the only thing in the current working directory is "fabric-samples"

nathalie@nathalie-HP-EliteBook-8460p:~/Hyperledger/LFS171x/Fabric$ ls
fabric-samples

I have to look in the bin subdirectory of fabric-samples:
nathalie@nathalie-HP-EliteBook-8460p:~/Hyperledger/LFS171x/Fabric$ ls fabric-samples/bin
configtxgen cryptogen fabric-ca-client idemixgen peer
configtxlator discover get-docker-images.sh orderer

This is on a Linux box running Ubuntu 16.04.

@DBAti
Copy link

DBAti commented Oct 22, 2018 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DBAti DBAti DBAti left review comments

@tkuhrt tkuhrt tkuhrt left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nathalie-ckc @atc-vince @DBAti @tkuhrt