This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: Add "no proof check" option for VC decoding #1012
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1002
Signed-off-by: Dima [email protected]
The main goal of this feature is to provide an option to disable JWS proof checks (i.e. JWT signature check) for VC Test Suite.
This is done on purpose as the Suite is focused on testing the VC data model and it does not suppose to test the cryptographic proofs (see w3c/vc-test-suite#101).
It turned out that JWS test input file containing VC from VC Test Suite has invalid data model (w3c/vc-test-suite#103) and thus the patch of that file (https://github.com/hyperledger/aries-framework-go/blob/1674d601e90b7b86e8d9b0ef56e7981517ccf993/scripts/run_vc_test_suite.sh#L42) is still present.