Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

feat: Add "no proof check" option for VC decoding #1012

Merged
merged 1 commit into from
Dec 21, 2019

Conversation

kdimak
Copy link
Contributor

@kdimak kdimak commented Dec 20, 2019

closes #1002

Signed-off-by: Dima [email protected]

The main goal of this feature is to provide an option to disable JWS proof checks (i.e. JWT signature check) for VC Test Suite.
This is done on purpose as the Suite is focused on testing the VC data model and it does not suppose to test the cryptographic proofs (see w3c/vc-test-suite#101).
It turned out that JWS test input file containing VC from VC Test Suite has invalid data model (w3c/vc-test-suite#103) and thus the patch of that file (https://github.com/hyperledger/aries-framework-go/blob/1674d601e90b7b86e8d9b0ef56e7981517ccf993/scripts/run_vc_test_suite.sh#L42) is still present.

@codecov
Copy link

codecov bot commented Dec 20, 2019

Codecov Report

Merging #1012 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1012   +/-   ##
=======================================
  Coverage   90.88%   90.88%           
=======================================
  Files          93       93           
  Lines        5856     5856           
=======================================
  Hits         5322     5322           
  Misses        290      290           
  Partials      244      244
Impacted Files Coverage Δ
pkg/doc/verifiable/presentation_jws.go 100% <100%> (ø) ⬆️
pkg/doc/verifiable/credential_jws.go 100% <100%> (ø) ⬆️
pkg/doc/verifiable/presentation.go 89.39% <100%> (-0.16%) ⬇️
pkg/doc/verifiable/credential.go 92.97% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1674d60...24ae483. Read the comment docs.

@troyronda troyronda merged commit 13f3e71 into hyperledger-archives:master Dec 21, 2019
@kdimak kdimak deleted the issue-1002 branch December 22, 2019 15:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add "no proof check" option for VC decoding
3 participants