Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

feat: mysql Batch() #110

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Conversation

llorllale
Copy link

Signed-off-by: George Aristy [email protected]

@llorllale llorllale added the enhancement New feature or request label Apr 29, 2021
@llorllale llorllale self-assigned this Apr 29, 2021
@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #110 (c58f6b2) into main (553740e) will decrease coverage by 3.43%.
The diff coverage is 85.00%.

❗ Current head c58f6b2 differs from pull request most recent head 7c94361. Consider uploading reports for the commit 7c94361 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   89.01%   85.57%   -3.44%     
==========================================
  Files           1        1              
  Lines         446      305     -141     
==========================================
- Hits          397      261     -136     
+ Misses         28       22       -6     
- Partials       21       22       +1     
Impacted Files Coverage Δ
component/storage/mysql/store.go 85.57% <85.00%> (ø)
component/storage/couchdb/store.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 553740e...7c94361. Read the comment docs.

Signed-off-by: George Aristy <[email protected]>
@@ -416,6 +492,7 @@ func (s *store) Close() error {
return nil
}

// TODO optimize tagMap: https://github.com/hyperledger/aries-framework-go-ext/issues/109
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this issue here: #88

(My intention is to eventually use proper columns+indexing instead of the "tag map")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that I forgot to include a reference to #88 in the code... oops...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok - I closed #109

@llorllale llorllale merged commit a747218 into hyperledger-archives:main Apr 29, 2021
@llorllale llorllale deleted the mysql_batch branch April 29, 2021 19:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants