Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run sealevel E2E in parallel with EVM #5280

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

kamiyaa
Copy link
Collaborator

@kamiyaa kamiyaa commented Jan 24, 2025

Description

  • separate evm e2e tests with sealevel e2e tests
  • update github CI to run these 2 tests in parallel

Drive-by changes

  • refactor relative paths code to use more absolute paths
  • update working directory code to be more reliable

Related issues

Issue DNE

Backward compatibility

yes

Testing

cargo test --release --package run-locally --bin run-locally --features sealevel -- sealevel::test --nocapture

Copy link

changeset-bot bot commented Jan 24, 2025

⚠️ No Changeset found

Latest commit: 9ee17b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (09e1d5b) to head (049f4ed).
Report is 25 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5280   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@kamiyaa kamiyaa force-pushed the jeff/parallel-e2e-3 branch 2 times, most recently from 926bb0b to 31a0ab2 Compare January 24, 2025 11:16
 - separate evm e2e tests with sealevel e2e tests
  - refactor relative paths code to use more absolute paths
  - update working directory code to be more reliable
 - update github CI to run these 2 tests in parallel
@kamiyaa kamiyaa force-pushed the jeff/parallel-e2e-3 branch from 316a7f2 to 8c14c77 Compare January 24, 2025 12:08
@kamiyaa kamiyaa force-pushed the jeff/parallel-e2e-3 branch from ea406ce to 6908dd6 Compare January 24, 2025 13:05
@kamiyaa kamiyaa marked this pull request as ready for review January 26, 2025 15:34
@kamiyaa kamiyaa requested a review from tkporter as a code owner January 26, 2025 15:34
@kamiyaa
Copy link
Collaborator Author

kamiyaa commented Jan 27, 2025

I think we probably want to merge
#5132
and
#5182

before this one because they all modify the e2e tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

3 participants