Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove coingecko-api-v3 library and de-dupe fetching utils #4837

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

jmrossy
Copy link
Contributor

@jmrossy jmrossy commented Nov 7, 2024

Description

  • Remove coingecko-api-v3 lib which is unnecessary and breaks bundling
  • Remove getCoingeckoTokenPrices function which is redundant with CoinGeckoTokenPriceGetter
  • Simplify CoinGeckoTokenPriceGetter and remove need for Mock class

Related: #4787

See discussion here: https://discord.com/channels/935678348330434570/1304125818817220653

Drive-by changes

  • Fix bundling issue with Storybook in widgets lib

Backward compatibility

No

Testing

Rewrote unit tests and tested Storybook

Copy link

changeset-bot bot commented Nov 7, 2024

🦋 Changeset detected

Latest commit: 5386679

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/sdk Major
@hyperlane-xyz/cli Major
@hyperlane-xyz/helloworld Major
@hyperlane-xyz/infra Major
@hyperlane-xyz/widgets Major
@hyperlane-xyz/ccip-server Major
@hyperlane-xyz/github-proxy Major
@hyperlane-xyz/utils Major
@hyperlane-xyz/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.58%. Comparing base (884b00c) to head (5386679).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4837   +/-   ##
=======================================
  Coverage   74.58%   74.58%           
=======================================
  Files         103      103           
  Lines        1515     1515           
  Branches      195      195           
=======================================
  Hits         1130     1130           
  Misses        364      364           
  Partials       21       21           
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 77.77% <ø> (ø)
isms 79.02% <ø> (ø)
token 89.01% <ø> (ø)
middlewares 77.58% <ø> (ø)

@jmrossy jmrossy added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit 5f41b11 Nov 7, 2024
35 checks passed
@jmrossy jmrossy deleted the rossy/storybook-fix branch November 7, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants