Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix path #4828

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix path #4828

wants to merge 1 commit into from

Conversation

drewstone
Copy link

@drewstone drewstone commented Nov 6, 2024

Description

Fix the path in StaticAggregationIsm.sol. I can't copy the test files into my own solidity project due to this path issue.

Pls issue new npm package if this is merged 🫶

Copy link

changeset-bot bot commented Nov 6, 2024

⚠️ No Changeset found

Latest commit: ac805f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@aroralanuk aroralanuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, can you also add this fix to other contracts like AbstractMessageIdAuthorizedIsm?

@@ -5,7 +5,7 @@ pragma solidity >=0.8.0;
import {AbstractAggregationIsm} from "./AbstractAggregationIsm.sol";
import {AggregationIsmMetadata} from "../../isms/libs/AggregationIsmMetadata.sol";
import {MetaProxy} from "../../libs/MetaProxy.sol";
import {PackageVersioned} from "contracts/PackageVersioned.sol";
import {PackageVersioned} from "../../contracts/PackageVersioned.sol";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import {PackageVersioned} from "../../contracts/PackageVersioned.sol";
import {PackageVersioned} from "../../PackageVersioned.sol";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants