Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use chain name or domain as identifier instead of chainId #136

Merged
merged 6 commits into from
Nov 7, 2024

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented Nov 6, 2024

relates to:

testing:

  • update SDK to latest once monorepo PR is merged + rolled out
  • add duplicate chain metadata with different domain id to custom yaml

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperlane-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 1:47am

Copy link
Collaborator

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far!

src/features/messages/pi-queries/fetchPiChainMessages.ts Outdated Show resolved Hide resolved
src/utils/explorers.ts Outdated Show resolved Hide resolved
src/components/search/SearchFilterBar.tsx Outdated Show resolved Hide resolved
@paulbalaji paulbalaji merged commit b8e0d31 into main Nov 7, 2024
6 checks passed
@paulbalaji paulbalaji deleted the pb/chainid-decouple branch November 7, 2024 14:16
github-merge-queue bot pushed a commit to hyperlane-xyz/hyperlane-registry that referenced this pull request Nov 7, 2024
### Description

only merge this AFTER
hyperlane-xyz/hyperlane-explorer#136 is merged

Migrate metadata for sept26 chain deployment batch
- `immutablezkevm` -> `immutablezkevmmainnet`
- `rari` -> `rarichain`
- `rootstock` -> `rootstockmainnet`
- `alephzeroevm` -> `alephzeroevmmainnet`
- `chiliz` -> `chilizmainnet`
- `lumia` -> `lumiaprism`
- `superposition` -> `superpositionmainnet`
- `flow` -> `flowmainnet`
	- unfortunately `flowevm` was burned during deployment
- `metall2` -> `metal`
- `polynomial` -> `polynomialfi`

new domainids all have `10000` prefixed

also updates the gecko ID for lumia

### Backward compatibility

not really, all the deprecated chains have a new name now

### Testing

tbd, manual

---------

Signed-off-by: pbio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants