-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use chain name or domain as identifier instead of chainId #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
paulbalaji
commented
Nov 6, 2024
paulbalaji
commented
Nov 6, 2024
paulbalaji
commented
Nov 6, 2024
jmrossy
reviewed
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far!
jmrossy
approved these changes
Nov 6, 2024
Signed-off-by: pbio <[email protected]>
Signed-off-by: pbio <[email protected]>
paulbalaji
force-pushed
the
pb/chainid-decouple
branch
from
November 7, 2024 01:45
4adac7e
to
ab70519
Compare
github-merge-queue bot
pushed a commit
to hyperlane-xyz/hyperlane-registry
that referenced
this pull request
Nov 7, 2024
### Description only merge this AFTER hyperlane-xyz/hyperlane-explorer#136 is merged Migrate metadata for sept26 chain deployment batch - `immutablezkevm` -> `immutablezkevmmainnet` - `rari` -> `rarichain` - `rootstock` -> `rootstockmainnet` - `alephzeroevm` -> `alephzeroevmmainnet` - `chiliz` -> `chilizmainnet` - `lumia` -> `lumiaprism` - `superposition` -> `superpositionmainnet` - `flow` -> `flowmainnet` - unfortunately `flowevm` was burned during deployment - `metall2` -> `metal` - `polynomial` -> `polynomialfi` new domainids all have `10000` prefixed also updates the gecko ID for lumia ### Backward compatibility not really, all the deprecated chains have a new name now ### Testing tbd, manual --------- Signed-off-by: pbio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to:
testing: