This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
Changes to allow "votable" config for votable ERC20 warp routes #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanthepythonguy
commented
Jun 23, 2023
armanthepythonguy
commented
- Added an optional config in warpRouteConfig
- Added an optional votable field to synthetics in WarpRouteDeployer
nambrot
reviewed
Jun 26, 2023
config/warp_tokens.ts
Outdated
| @@ -5,6 +5,7 @@ import type { WarpRouteConfig } from '../src/warp/config'; | |||
| // A config for deploying Warp Routes to a set of chains | |||
| // Not required for Hyperlane core deployments | |||
| export const warpRouteConfig: WarpRouteConfig = { | |||
| // votable:true You can enable this config if you want to make your synthetic ERC20 tokens votable | |||
There was a problem hiding this comment.
Put these on different lines to make it obvious that votable is something that can be commented out
There was a problem hiding this comment.
Actually, shouldn't this be on the synthetics part of the config? So move it to line 21?
There was a problem hiding this comment.
I have updated it. Now you have the votable options both in the base as well as the synthetic chain. If votable is true in the base chain it will deploy the HypERC20CollateralVotable.sol and similarly, in the synthetic chain HypERC20Votable.sol
nambrot
reviewed
Jun 30, 2023
| }, | ||
| ], | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Remove this whitespace change
src/warp/WarpRouteDeployer.ts
Outdated
| @@ -119,9 +118,12 @@ export class WarpRouteDeployer { | |||
| JSON.stringify(configMap[baseChainName]), | |||
| ); | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Unnecessary whitespace change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.